Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes double slashes from URL #1639

Merged

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Mar 22, 2016

No description provided.

@gluneau gluneau added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) SQL PR contains SQL modifications such as schema changes and new SQL scripts labels Mar 22, 2016
@gluneau gluneau added this to the 16.0 milestone Mar 22, 2016
@gluneau
Copy link
Contributor Author

gluneau commented Mar 22, 2016

I will update the wiki when this is merged as to suggest not putting a slash at the end of the url

https://github.com/aces/Loris/wiki/Project-Customization

@codecov-io
Copy link

Current coverage is 14.91%

Merging #1639 into 16.04-dev will decrease coverage by -0.28% as of 436fde6

@@            16.04-dev   #1639   diff @@
=========================================
  Files             121     121        
  Stmts           19754   19615    -139
  Branches            0       0        
  Methods          1068           +1068
=========================================
- Hit              3002    2925     -77
  Partial             0       0        
+ Missed          16752   16690     -62

Review entire Coverage Diff as of 436fde6

Powered by Codecov. Updated on successful CI builds.

@MounaSafiHarab
Copy link
Contributor

@gluneau,

this does not seem to fix it for me (I had the error initially without the '/' present in the url). The error is only for the "back to list" link which should take you to href:/imaging_browser/, but is taking me to href://imaging_browser/ (double forward slash '//' instead of single '/')

@gluneau
Copy link
Contributor Author

gluneau commented Mar 29, 2016

Missing schema patch

@MounaSafiHarab
Copy link
Contributor

@gluneau,
works for me now (I tested only the Imaging Browser/ViewSession/Back to List link (under Navigation) which was the link causing the problem).

@jstirling91
Copy link
Contributor

You should alter the default schema as well

@jstirling91 jstirling91 added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Mar 30, 2016
@gluneau gluneau force-pushed the Imaging-browser-Navigation-links-broken branch from df88f6b to 907780b Compare April 1, 2016 14:45

-- Reports menu
UPDATE LorisMenu SET Link='statistics/' WHERE Link='main.php?test_name=statistics';
UPDATE LorisMenu SET Link='dqt/' WHERE Link='/dqt/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should UPDATE to link = dataquery where ...

@xlecours
Copy link
Contributor

xlecours commented Apr 1, 2016

This should be a new patch instead of a modification on an old one

@gluneau gluneau removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Apr 1, 2016
@gluneau gluneau force-pushed the Imaging-browser-Navigation-links-broken branch from 8994caa to 229d219 Compare April 1, 2016 19:59
@driusan driusan merged commit 5acf705 into aces:16.04-dev Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants