Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQT moving study consent & study consent withdrawal from where clause to fields drop down #1681

Merged
merged 3 commits into from
Apr 15, 2016
Merged

DQT moving study consent & study consent withdrawal from where clause to fields drop down #1681

merged 3 commits into from
Apr 15, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Apr 8, 2016

DQT users of Demographics will have to pro-actively filter for study consent to only use data where consent was not removed.

@gluneau gluneau added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs) labels Apr 8, 2016
@gluneau gluneau added this to the 16.0 milestone Apr 8, 2016
@gluneau gluneau changed the title Dqt without study consent or study consent withdrawal filter DQT moving study consent & study consent withdrawal from where clause to fields drop down Apr 8, 2016
@codecov-io
Copy link

Current coverage is 14.94%

Merging #1681 into 16.04-dev will decrease coverage by -0.23% as of d696b3e

@@            16.04-dev   #1681   diff @@
=========================================
  Files             122     121     -1
  Stmts           19785   19733    -52
  Branches            0       0       
  Methods          1074    1074       
=========================================
- Hit              3002    2950    -52
  Partial             0       0       
  Missed          16783   16783

Review entire Coverage Diff as of d696b3e

Powered by Codecov. Updated on successful CI builds.

driusan
driusan reviewed Apr 12, 2016
View reviewed changes
tools/CouchDB_Import_Demographics.php
),
'Study_consent' => array(
'Description' => 'Study Consent',
'Type' => "int(10)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is consent an integer? Shouldn't it be either a varchar or an enum?

@samirdas samirdas merged commit 82a8f40 into aces:16.04-dev Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@driusan driusan

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs)
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gluneau @codecov-io @driusan @samirdas