Bring release patch in line with schema and patch #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
Cleanup
|
The update statements from 2016-03-22-ConfigRemoveLastSlashFromURL.sql seem to already be on line 280 and 281 of the release patch. Am I missing something? |
Current coverage is 14.30%@@ 16.04-dev #1859 diff @@
===========================================
Files 118 118
Lines 19653 19653
Methods 1084 1084
Messages 0 0
Branches 0 0
===========================================
Hits 2811 2811
Misses 16842 16842
Partials 0 0
|
|
My patch needed to be put at the end of the release patch to catch all of the menu entries. Thank you @xlecours for the discussion on Friday on patch ordering. |
xlecours
pushed a commit
to xlecours/Loris
that referenced
this pull request
Jun 1, 2016
* Bring release patch in line with schema and patch * move removing of slash at the end of release patch * put back extra slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
Loris/SQL/0000-00-00-schema.sql
and
Loris/SQL/Archive/16.0/2016-03-22-ConfigRemoveLastSlashFromURL.sql