Imaging browser undef variables and missing prepare array #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
the
Cleanup
|
I don't have any problems with this change, but I think it should go to 16.1. I don't think it's that urgent to fix a warning which doesn't break anything when we're already at RC2. |
|
On second thought, I just noticed the fix to the prepared statement, which I think should absolutely go in.. though I'm not sure why they're in the same pull request. |
| @@ -578,9 +578,10 @@ class NDB_Form_Imaging_Browser extends NDB_Form | |||
| $depends = parent::getJSDependencies(); | |||
| if($this->page === 'viewSession') { | |||
| $factory = NDB_Factory::singleton(); | |||
| $baseURL = $factory->settings()->getBaseURL(); | |||
| $baseurl = $factory->settings()->getBaseURL(); | |||
There was a problem hiding this comment.
Also this variable was also wrong, if the baseurl has a directory, it would fail without this fix.
Current coverage is 14.34%
@@ 16.04-dev #1869 diff @@
===========================================
Files 118 118
Lines 19653 19655 +2
Methods 1084 1084
Messages 0 0
Branches 0 0
===========================================
+ Hits 2811 2819 +8
+ Misses 16842 16836 -6
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed js file and added it to the getJSDependencies, that fixes this warning:
WARNING: Relying on imaging_browser.js getting automatically loaded will soon be removed. Override getJSDependencies() instead