Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM Archive: fixed the under incremented rowData index for links #1894

Merged

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Jun 8, 2016

Why are we using hard coded indexes again?

@gluneau gluneau added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jun 8, 2016
@gluneau gluneau added this to the 16.0 milestone Jun 8, 2016
@codecov-io
Copy link

codecov-io commented Jun 8, 2016

Current coverage is 14.32%

Merging #1894 into 16.04-dev will increase coverage by 0.02%

  1. 2 files (not in diff) in php/libraries were modified. more
    • Misses -5
    • Hits +5
@@           16.04-dev      #1894   diff @@
===========================================
  Files            118        118          
  Lines          19656      19656          
  Methods         1084       1084          
  Messages           0          0          
  Branches           0          0          
===========================================
+ Hits            2811       2816     +5   
+ Misses         16845      16840     -5   
  Partials           0          0          

Sunburst

Powered by Codecov. Last updated by 663a1ad...5565778

@driusan driusan assigned ridz1208 and unassigned jstirling91 Jun 8, 2016
@gluneau
Copy link
Contributor Author

gluneau commented Jun 8, 2016

We have a variable number of columns based on config.
See: #1703

@driusan driusan merged commit 24e202d into aces:16.04-dev Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants