Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CouchDB] Add date of birth to Demographics #2186

Merged
merged 2 commits into from
Sep 23, 2016
Merged

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Sep 14, 2016

This adds date of birth to the couchdb importer for the #data_query_tool

@gluneau gluneau added the Feature PR or issue introducing/requiring at least one new feature label Sep 14, 2016
@gluneau gluneau added this to the 17.0 milestone Sep 14, 2016
@codecov-io
Copy link

Current coverage is 13.72% (diff: 100%)

Merging #2186 into 17.0-dev will not change coverage

@@           17.0-dev      #2186   diff @@
==========================================
  Files           118        118          
  Lines         20107      20107          
  Methods        1124       1124          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2759       2759          
  Misses        17348      17348          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update b6cbaaf...d4809c0

Copy link
Collaborator

@ridz1208 ridz1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes 0.6 ms additional time to run the query

@ridz1208
Copy link
Collaborator

@gluneau I tested that the query returns exactly the same number of rows.

import test still required

@ridz1208 ridz1208 added PassedCodeReview Passed Manual Tests PR has undergone proper testing by at least one peer labels Sep 21, 2016
@driusan driusan merged commit ef2fe0c into aces:17.0-dev Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR or issue introducing/requiring at least one new feature Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants