Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Enable project libraries override #2187

Merged
merged 1 commit into from
Oct 12, 2016
Merged

[core] Enable project libraries override #2187

merged 1 commit into from
Oct 12, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Sep 14, 2016 •
edited
Loading

Allows project to override libraries

The directory "project/libraries" has to exist for composer to run.

@gluneau gluneau added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Sep 14, 2016
@gluneau gluneau added this to the 16.1.1 milestone Sep 14, 2016
@gluneau gluneau added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Sep 15, 2016
@driusan driusan modified the milestones: 17.0, 16.1.1 Sep 16, 2016
@driusan driusan added Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch and removed Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties labels Sep 23, 2016
@gluneau gluneau changed the base branch from 16.1-dev to 17.0-dev October 5, 2016 18:42
@gluneau gluneau removed the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label Oct 5, 2016
@mohadesz mohadesz added PassedCodeReview Passed Manual Tests PR has undergone proper testing by at least one peer and removed Request Code Review labels Oct 11, 2016
@samirdas samirdas merged commit 3b0bd34 into aces:17.0-dev Oct 12, 2016
@alisterdev
Copy link
Contributor

@gluneau @driusan If users don't have the project/libraries folder created, composer install will fail. Should probably be indicated somewhere in the docs

@gluneau gluneau added the Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) label Oct 13, 2016
@alisterdev
Copy link
Contributor

Made a PR to prevent this situation from happening #2282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohadesz mohadesz mohadesz approved these changes

Assignees

@driusan driusan

Labels
Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gluneau @alisterdev @mohadesz @driusan @samirdas