[Consent] Group consents + Improve UI #6044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
the
Needs Code Formatting
|
LGTM. Final verdict will wait rebase after #6042 is merged |
johnsaigle
added
Blocked
|
Adding Blocked as the other PR should be merged first (right?) |
PapillonMcGill
previously approved these changes
Feb 25, 2020
PapillonMcGill
added
the
Passed Manual Tests
|
Just one note, |
|
@PapillonMcGill that has to do with data validation and is not something touched in this PR. might be a good call to add it to github issues? @ridz1208 what do you think? should consent withdrawal date be checked to be after the given date of consent? |
|
@PapillonMcGill @zaliqarosli in theory it makes sense. outside the scope of this PR. |
|
@ridz1208 @PapillonMcGill okay i'll add it as an issue |
zaliqarosli
added
the
Needs Rebase
|
This has conflicts and needs to be rebased |
zaliqarosli
added
the
Needs Work
zaliqarosli
force-pushed
the
2020-02-10-AddParentToConsentUI
branch
from
4e3703c
to
499e064
Compare
zaliqarosli
removed
the
Needs Work
ridz1208
reviewed
Aug 6, 2020
ridz1208
reviewed
Aug 6, 2020
ridz1208
added
Feature
driusan
pushed a commit
that referenced
this pull request
Aug 11, 2020
Adds ConsentGroupID to consent table (schema + patch) This keeps the Consent Status tab rendering the same. Only the back-end is affected in this PR. This feature is increasingly in demand from projects who would like to split up consents via e.g. consent forms. See also #6044 for front-end changes.
|
Whenever I try to add a new consent group I get the following errors on the front-end:
|
driusan
added
Needs Rebase
edit raisinbread remove undefined index php notice query for non parent consents to populate frontend travis change from consent parent to consent grouping fix raisinbread group raisinbread consent fix patch exchange parentID for groupID lintphp fix schema modify sql table and add patch edit raisinbread remove undefined index php notice query for non parent consents to populate frontend improve frontend remove unnecessary ParentID query travis eslint update parentID to consentGroupID delete old patch php lint parent to group
zaliqarosli
force-pushed
the
2020-02-10-AddParentToConsentUI
branch
from
f054b3b
to
84a03e1
Compare
zaliqarosli
removed
the
Needs Rebase
|
@zaliqarosli yes the issue is fixed! looks good :) |
jesscall
previously approved these changes
Aug 12, 2020
jesscall
added
the
Passed Manual Tests
|
@zaliqarosli could you add some content to the changelog please? |
|
@ridz1208 re-review please! |
ridz1208
approved these changes
Aug 12, 2020
driusan
reviewed
Aug 17, 2020
Co-authored-by: Dave MacFarlane <driusan@gmail.com>
zaliqarosli
added a commit
to zaliqarosli/Loris
that referenced
this pull request
Sep 3, 2020
- Adds vertical tabs for each parent consent and renders within that tab all the children consents - For each consent rendering: adds a HeaderElement for the consent label, changes label for Yes/No select Element to 'Response', changes label for Date element to 'Date of Response' - Hides Consent history by default - Add Show/Hide Consent history toggling - Cleans up the rendering of the history string
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
Adds ConsentGroupID to consent table (schema + patch) This keeps the Consent Status tab rendering the same. Only the back-end is affected in this PR. This feature is increasingly in demand from projects who would like to split up consents via e.g. consent forms. See also aces#6044 for front-end changes.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Adds ConsentGroupID to consent table (schema + patch) This keeps the Consent Status tab rendering the same. Only the back-end is affected in this PR. This feature is increasingly in demand from projects who would like to split up consents via e.g. consent forms. See also aces#6044 for front-end changes.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
- Adds vertical tabs for each parent consent and renders within that tab all the children consents - For each consent rendering: adds a HeaderElement for the consent label, changes label for Yes/No select Element to 'Response', changes label for Date element to 'Date of Response' - Hides Consent history by default - Add Show/Hide Consent history toggling - Cleans up the rendering of the history string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
PR 2 of 2. This PR includes changes from #6042 and will need to be rebased once #6042 has been merged.
This PR follows the first PR by rendering the grouping of consents and improves other aspects of the UI.
This PR:
Testing instructions (if applicable)
consentfor consent grouping #6042