[issue_tracker] Update validation to allow NULL Site #6526

laemtl · 2020-05-12T23:45:40Z

Brief summary of changes

Since we want to allow new issues with NULL centerID to be created, the following changes have been made:

Add/Edit issue

a new Site option All Sites allows a user to save an issue with a NULL site
The Comment History section displays site to All sites if an issue is edited/modified with the All Sites option.
Alternatively, in the Comment History section, All sites can be replaced with a comma separated list of all CenterID (to discuss)

Index

An issue with a null centerID displays All Sites in the site column
Issues can be filtered by sites: All Sites.
Alternatively, All sites can be replaced with a comma separated list of all CenterID (to discuss) in the datatable column, and sites can be made multi-selectable.

Test plan

Add modification to test instructions to handle the NULL CenterIDs
Reintroduce Attachment testing instruction deleted by accident in [Documentation] Issue Tracker test plan update #6636

Linked Issues

Resolves [issue_tracker] Update validation to allow NULL Site #6518

driusan · 2020-05-13T19:35:31Z

does this need a test plan update?

cmadjar · 2020-05-15T13:26:16Z

@laemtl Could you update the test plan accordingly? Thank you!

laemtl · 2020-05-15T14:08:09Z

@driusan, @cmadjar Sure!

christinerogers

Thanks Laetitia. good catch @cmadjar re the test plan. I've suggested a little more granularity in the update to the test plan.
Laetitia does this make sense to you, and could you fill in what is supposed to happen on the new testing point 7 ( see my suggestion/comment) -- merci !

christinerogers · 2020-05-15T20:36:15Z

modules/issue_tracker/test/issue_tracker_test_plan.md

+5. Submit invalid and valid PSCID and visit label pairs. Error messages should respond accordingly. Not that you cannot submit PSCIDs from other sites unless you have access all profiles permission
+6. Submit just a visit label - this should give an error message.
+7. Check that all values are propagated and saved correctly.
+8. Add an attachment to the new issue and make sure that it is successfully uploaded.
+9. Check that watching logging is working - turn it off and on for your current user, and for other watchers on the issue


Suggested change

5. Submit invalid and valid PSCID and visit label pairs. Error messages should respond accordingly. Not that you cannot submit PSCIDs from other sites unless you have access all profiles permission

6. Submit just a visit label - this should give an error message.

7. Check that all values are propagated and saved correctly.

8. Add an attachment to the new issue and make sure that it is successfully uploaded.

9. Check that watching logging is working - turn it off and on for your current user, and for other watchers on the issue

5. Submit invalid and valid PSCID and visit label pairs. Error messages should display accordingly.

6. A user should be able to submit a PSCID from other sites only if they have access_all_profiles permission.

7. Submit a PSCID and leave the Site blank _ .. this should/not work if... _

8. Submit just a visit label - this should give an error message.

9. Check that all values are propagated and saved correctly.

10. Add an attachment to the new issue and make sure that it is successfully uploaded.

11. Check that watching logging is working - turn it off and on for your current user, and for other watchers on the issue.

Breaking down testing point 5.

To do : Point 7 - needs to be completed with what should be happening when a PSCID is entered with Null site.

@christinerogers Are 7. and 3. redundant?

I see your point.
3 could specify that PSCID is left blank.
7 tests the case where there is a PSCID, and Site doesn't match or is null.

christinerogers

Thanks @laemtl

driusan · 2020-05-19T18:00:59Z

modules/issue_tracker/test/issue_tracker_test_plan.md

@@ -6,16 +6,20 @@ Issue Tracker Filter Form [Automation Testing]
 5. Test that the watching checkbox works correctly (issues that your userID is watching in issues_watching table)
 6. Check that links to issues in table are correct.
 7. Check that table sorts and displays additional pages correctly 
+8. Check that a user who does not have access to all centers can see all issues with a site set to NULL.


this should say what permission it's referring to, since we have like 20 different access all site permissions..

christinerogers

Refining your change after dave's comment - see my comment about how User Accounts is used for this purpose (and this doesn't need to be explained).
Otherwise LGTM 👍

modules/issue_tracker/test/issue_tracker_test_plan.md

christinerogers · 2020-05-22T18:52:28Z

failing travis 😢 i know alex and shen are working on this

christinerogers

thanks Laetitia, looks great to me.

This will need to be tested in Round 3 of 23 release testing, since it hasn't been merged/pulled onto the Test Vm for Round 2.

HenriRabalais

Perhaps to make it more intuitive the user, we should replace the empty option in the drop down to a string that says "All" to make it clear that by not selecting a site, they are in fact selecting all sites.

christinerogers · 2020-05-27T16:01:16Z

Perhaps to make it more intuitive the user, we should replace the empty option in the drop down to a string that says "All" to make it clear that by not selecting a site, they are in fact selecting all sites.

👍

This used to be the practice across all module filters before Reactification, or at least many filters. @HenriRabalais Do you remember why we discontinued?

HenriRabalais · 2020-05-27T16:41:28Z

@christinerogers iirc that was because it made the filter feel really busy with values that didn't need to be there. For filters, it's implied that if there's no value in the field, it's not filtering on that field (no value in filter field == no filtering for that field == all values for that field are presented).

But for forms I don't think that same implication holds. It's expected that an empty field literally means that the value submitted will be NULL. If in this particular case for centerIds we are taking a NULL value in the back end to mean "All Sites", then I think the "All Sites" part is what should be communicated to the user on the front end. This way, the field would still be required, but they would have the option of selecting "All Sites".

christinerogers · 2020-05-27T19:28:13Z

Thanks @HenriRabalais, good points - I wonder what the odds are we'll get a user confused because they entered an issue for "All Sites" but can't filter on that literal value.

driusan · 2020-06-01T14:26:12Z

@HenriRabalais GitHub says you requested changes but it's not clear from the thread what changes you want her to make on this PR.. is there something outstanding?

Regarding the underlying issue, what if there was an emptyValue=string prop (or similar) so that forms could set the label they want for the empty value without affecting all of our filters?

HenriRabalais

@driusan I'll make requested changes more clear:

I think that CenterID should remain a required field for submission, however an option should be available for the user that displays as "All Sites", but submits a NULL value to be stored in the datatable.

driusan

see Henri's review

Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>

laemtl · 2020-06-17T22:35:34Z

@HenriRabalais I updated the code following your suggestion.

HenriRabalais

Looks good! just some left over console log. I'll test out the PR and give it an approval if it passes.

HenriRabalais · 2020-06-18T14:09:48Z

modules/issue_tracker/jsx/issueTrackerIndex.js

-      result = <td>{this.state.data.fieldOptions.sites[cell]}</td>;
+      // if cell is an array containing all sites values
+      console.log(this.state.data.centerIDs);
+      console.log(cell);


looks like some forgotten console logs

ridz1208 · 2020-07-02T15:33:01Z

@driusan @HenriRabalais please re-review

HenriRabalais

I think this does what it aims to do!

stale review

Add ability to set a site to null to denote "all sites" in the issue tracker. Also update test plan both to handle this case and reintroduce Attachment testing instruction deleted by accident in aces#6636 Resolves aces#6518

laemtl added 23.0.0-testing Feature PR or issue introducing/requiring at least one new feature labels May 12, 2020

ridz1208 assigned laemtl May 15, 2020

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch from 6ff3e2a to ca1fe3b Compare May 15, 2020 20:24

christinerogers requested changes May 15, 2020

View reviewed changes

christinerogers approved these changes May 19, 2020

View reviewed changes

driusan reviewed May 19, 2020

View reviewed changes

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch 4 times, most recently from 9f02f64 to 43a2fa0 Compare May 19, 2020 20:26

christinerogers requested changes May 19, 2020

View reviewed changes

modules/issue_tracker/test/issue_tracker_test_plan.md Outdated Show resolved Hide resolved

laemtl requested a review from christinerogers May 22, 2020 18:38

christinerogers previously approved these changes May 22, 2020

View reviewed changes

christinerogers requested a review from HenriRabalais May 22, 2020 19:07

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch from 0ab8463 to 6fc6548 Compare May 25, 2020 22:08

ridz1208 assigned HenriRabalais May 27, 2020

HenriRabalais suggested changes May 27, 2020

View reviewed changes

ridz1208 unassigned HenriRabalais May 29, 2020

HenriRabalais suggested changes Jun 1, 2020

View reviewed changes

driusan added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 2, 2020

driusan requested changes Jun 2, 2020

View reviewed changes

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch 2 times, most recently from 4350997 to 6264ad0 Compare June 15, 2020 06:21

laemtl requested a review from HenriRabalais June 16, 2020 18:13

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch from 6264ad0 to de317ae Compare June 16, 2020 18:32

laemtl changed the base branch from master to 23.0-release June 16, 2020 18:33

laemtl and others added 5 commits June 16, 2020 14:43

[issue_tracker] Update validation to allow NULL Site

cb65a7e

[Issue Tracker] Update TestPlan

9b2bdd9

Test Plan - Create New section (PSCID/NULL Site)

ebfd772

Update modules/issue_tracker/test/issue_tracker_test_plan.md

f43caca

Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>

All Sites: Comment History (edit) and Issues Table filters

ab5fdc9

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch from de317ae to ab5fdc9 Compare June 16, 2020 18:44

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch 4 times, most recently from 988cae5 to c02e59a Compare June 18, 2020 00:44

HenriRabalais reviewed Jun 18, 2020

View reviewed changes

Refactoring to remove use of 'all' in sites

e046121

laemtl force-pushed the 2020-05-12-new-issues-null-centerID branch from c02e59a to e046121 Compare June 18, 2020 14:16

laemtl requested a review from HenriRabalais June 18, 2020 14:17

HenriRabalais approved these changes Jul 7, 2020

View reviewed changes

driusan merged commit 382f308 into aces:23.0-release Jul 8, 2020

ridz1208 added this to the 23.0.2 milestone Jul 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[issue_tracker] Update validation to allow NULL Site #6526

[issue_tracker] Update validation to allow NULL Site #6526

laemtl commented May 12, 2020 •

edited

Loading

driusan commented May 13, 2020

cmadjar commented May 15, 2020

laemtl commented May 15, 2020 •

edited

Loading

christinerogers left a comment •

edited

Loading

christinerogers May 15, 2020

christinerogers May 15, 2020

laemtl May 19, 2020

christinerogers May 19, 2020

christinerogers left a comment

driusan May 19, 2020

christinerogers left a comment

christinerogers commented May 22, 2020

christinerogers left a comment

HenriRabalais left a comment

christinerogers commented May 27, 2020

HenriRabalais commented May 27, 2020

christinerogers commented May 27, 2020

driusan commented Jun 1, 2020

HenriRabalais left a comment •

edited

Loading

driusan left a comment

laemtl commented Jun 17, 2020

HenriRabalais left a comment

HenriRabalais Jun 18, 2020

ridz1208 commented Jul 2, 2020

HenriRabalais left a comment

[issue_tracker] Update validation to allow NULL Site #6526

[issue_tracker] Update validation to allow NULL Site #6526

Conversation

laemtl commented May 12, 2020 • edited Loading

Brief summary of changes

Add/Edit issue

Index

Test plan

Linked Issues

driusan commented May 13, 2020

cmadjar commented May 15, 2020

laemtl commented May 15, 2020 • edited Loading

christinerogers left a comment • edited Loading

Choose a reason for hiding this comment

christinerogers May 15, 2020

Choose a reason for hiding this comment

christinerogers May 15, 2020

Choose a reason for hiding this comment

laemtl May 19, 2020

Choose a reason for hiding this comment

christinerogers May 19, 2020

Choose a reason for hiding this comment

christinerogers left a comment

Choose a reason for hiding this comment

driusan May 19, 2020

Choose a reason for hiding this comment

christinerogers left a comment

Choose a reason for hiding this comment

christinerogers commented May 22, 2020

christinerogers left a comment

Choose a reason for hiding this comment

HenriRabalais left a comment

Choose a reason for hiding this comment

christinerogers commented May 27, 2020

HenriRabalais commented May 27, 2020

christinerogers commented May 27, 2020

driusan commented Jun 1, 2020

HenriRabalais left a comment • edited Loading

Choose a reason for hiding this comment

driusan left a comment

Choose a reason for hiding this comment

laemtl commented Jun 17, 2020

HenriRabalais left a comment

Choose a reason for hiding this comment

HenriRabalais Jun 18, 2020

Choose a reason for hiding this comment

ridz1208 commented Jul 2, 2020

HenriRabalais left a comment

Choose a reason for hiding this comment

laemtl commented May 12, 2020 •

edited

Loading

laemtl commented May 15, 2020 •

edited

Loading

christinerogers left a comment •

edited

Loading

HenriRabalais left a comment •

edited

Loading