Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] unittests for User.class.inc, UserPermissions.class.inc #6765

Merged
merged 3 commits into from
Jul 21, 2020
Merged

[Test] unittests for User.class.inc, UserPermissions.class.inc #6765

merged 3 commits into from
Jul 21, 2020

Conversation

AlexandraLivadas
Copy link
Contributor

@AlexandraLivadas AlexandraLivadas commented Jun 23, 2020 •
edited
Loading

Brief summary of changes

Unit tests for the User and UserPermissions libraries under php/libraries. This PR completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.

TODO:

  • Test for hasCenterPermission

Testing instructions (if applicable)

Run npm run tests:unit -- --filter UserTest or check out the Travis output.

@AlexandraLivadas AlexandraLivadas added the Testing PR contains test plan or automated test code (or config files for Travis) label Jun 23, 2020
@AlexandraLivadas AlexandraLivadas changed the title [Test] unittests for User.class.inc [Test] unittests for User.class.inc, UserPermissions.class.inc Jun 30, 2020
@AlexandraLivadas AlexandraLivadas marked this pull request as ready for review June 30, 2020 22:20
@AlexandraLivadas
Copy link
Contributor Author

This needs to be rebased with master due to the latest merged PR #5875

@AlexandraLivadas AlexandraLivadas added the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label Jul 2, 2020
@AlexandraLivadas AlexandraLivadas added Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix and removed Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch labels Jul 2, 2020
@AlexandraLivadas AlexandraLivadas removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jul 16, 2020
@AlexandraLivadas AlexandraLivadas requested review from kongtiaowang and removed request for kongtiaowang July 16, 2020 21:28
kongtiaowang
kongtiaowang approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandraLivadas AlexandraLivadas changed the base branch from master to main July 21, 2020 15:14
@driusan driusan merged commit 3ce0b19 into aces:main Jul 21, 2020
laemtl pushed a commit to laemtl/Loris that referenced this pull request Jul 21, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
b499294 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Jul 27, 2020
laemtl pushed a commit to laemtl/Loris that referenced this pull request Aug 3, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
ae993c1 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Aug 3, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
cabe2aa 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
spell00 pushed a commit to spell00/Loris that referenced this pull request Aug 13, 2020
@AlexandraLivadas @spell00
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
6ed79aa 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Aug 18, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
38f34b8 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Aug 20, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
47481f3 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Sep 10, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
f45e258 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Sep 10, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
4602fac 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Sep 11, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
f35e426 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Dec 12, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
bb4caa9 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Dec 14, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
fcd69f6 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
laemtl pushed a commit to laemtl/Loris that referenced this pull request Dec 15, 2020
@AlexandraLivadas @laemtl
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
693862c 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
AlexandraLivadas added a commit to AlexandraLivadas/Loris that referenced this pull request Jun 15, 2021
@AlexandraLivadas
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
a075480 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
AlexandraLivadas added a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@AlexandraLivadas
[Test] unittests for User.class.inc, UserPermissions.class.inc (aces#…
3162b23 
…6765)

Unit tests for the User and UserPermissions libraries under php/libraries. This completes the coverage of these two libraries.

Note: The functions getSiteNames and getCenterID are deprecated and are not covered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees
No one assigned
Labels
Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandraLivadas @kongtiaowang @driusan @ridz1208