[User accounts] New user email with pwd generation fix #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
added
the
Bug
laemtl
force-pushed
the
2020-06-30-new-user-pwd-fix
branch
2 times, most recently
from
d4de329
to
756255f
Compare
|
@laemtl i think this should be going to the 23 branch |
ridz1208
added
the
Critical to release
h-karim
approved these changes
Jul 2, 2020
h-karim
added
the
Passed Manual Tests
laemtl
force-pushed
the
2020-06-30-new-user-pwd-fix
branch
from
756255f
to
7432411
Compare
|
@ridz1208 Rebase done! |
ridz1208
approved these changes
Jul 2, 2020
|
@laemtl travis needs a nudge |
|
@ridz1208 Seemed related to a Travis issue... Validation is passing locally. |
|
Travis is not able to run the static suite: This is only happening on branch 23. I think the changes done to Travis in #5635 need to be merged in that branch too. |
|
@kongtiaowang can you look into this ? |
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
When adding a new LORIS user, page returns error "Your password cannot be your email" when both "Make user name match email address" and "Generate new password" are checked.
This adds another condition to check if NA_UserID is set, which fixes the issue.
Resolves aces#6802
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
When adding a new LORIS user, page returns error "Your password cannot be your email" when both "Make user name match email address" and "Generate new password" are checked.
This adds another condition to check if NA_UserID is set, which fixes the issue.
Resolves aces#6802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new LORIS user, page returns error "Your password cannot be your email" when both "Make user name match email address" and "Generate new password" are checked.
This PR adds another condition to check if NA_UserID is set, which fixes the issue.