Add AcquisitionDate field in the files table and back populate it #6892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Add to Release Notes
|
This seems to be missing the update to the query in the imaging browser? |
cmadjar
added
the
"Help! I don't understand Travis!"
|
@kongtiaowang can you help @cmadjar debug this? I can't figure out why it's getting stuck at "Waiting for mysqld...".. it gets past that for me locally. |
kongtiaowang
removed
the
"Help! I don't understand Travis!"
|
@kongtiaowang thank you! Let see if it passes Travis now. |
jesscall
approved these changes
Aug 12, 2020
|
Looks good! Ran the sql and double checked that the |
jesscall
added
the
Passed Manual Tests
driusan
reviewed
Aug 12, 2020
CHANGELOG.md
Outdated
| @@ -26,7 +27,7 @@ requesting a new account and will be displayed in the User Accounts module (PR # | |||
| ### Clean Up | |||
| - *Add item here* | |||
| ### Notes For Existing Projects | |||
| - *Add item here* | |||
| - Ensure to run the SQL patch to create and update the `AcquisitionDate` field in the `files` table (PR #6892) | |||
There was a problem hiding this comment.
I don't think this should be here.. it'll be part of the release patch when it's compiled.
There was a problem hiding this comment.
i agree. unless projects need to do a manual step other than the regular patch
There was a problem hiding this comment.
removed in the last commit
driusan
reviewed
Aug 12, 2020
|
@kongtiaowang this is still failing Travis. Do you know why? |
|
I think the main branch was broken, try rebasing. |
…iles table modified RB to have the dates in the files table update the CHANGELOG modifying imaging browser menu page modified the view session page to use the new files field for AcquisitionDate add debug to travis add debug to travis Update raisinbread/RB_files/RB_files.sql Co-authored-by: Shen <kongtiaowangshen@gmail.com> remove DEBUG from travis.yml Update .travis.yml Co-authored-by: Dave MacFarlane <driusan@gmail.com> modify CHANGELOG
cmadjar
force-pushed
the
add_acquisition_date_field_in_files_table
branch
from
a3cabf5
to
ddf500c
Compare
|
Just rebased it. Let's see if that breaks the curse ;) |
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Sep 3, 2020
…6892) This adds an AcquisitionDate column in the files table where the acquisition date of the files will be stored. If none are available for the file, then it will default to NULL. Resolves aces#6883 See also: aces/Loris-MRI#553 and aces/Loris-MRI#554
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
…6892) This adds an AcquisitionDate column in the files table where the acquisition date of the files will be stored. If none are available for the file, then it will default to NULL. Resolves aces#6883 See also: aces/Loris-MRI#553 and aces/Loris-MRI#554
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
…6892) This adds an AcquisitionDate column in the files table where the acquisition date of the files will be stored. If none are available for the file, then it will default to NULL. Resolves aces#6883 See also: aces/Loris-MRI#553 and aces/Loris-MRI#554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This adds an
AcquisitionDatecolumn in thefilestable where the acquisition date of the files will be stored. If none are available for the file, then it will default to NULL.Testing instructions (if applicable)
Ensure the SQL files can be run
Link(s) to related issue(s)