Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create timepoint] Language dropdown index fix #7145

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Nov 26, 2020

Small change to fix a reindexing of the languages, causing a database insert error (key constraint failure on languageID).

To test

Add languages to the database (language) at sparse indexes (ex: 2, 4).
You should be able to submit without a 500 error.

@laemtl laemtl added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Nov 26, 2020
@laemtl laemtl changed the base branch from main to 23.0-release November 26, 2020 19:40
@laemtl laemtl changed the base branch from 23.0-release to main November 26, 2020 19:45
@driusan
Copy link
Collaborator

driusan commented Nov 27, 2020

Replaced by #7146

@driusan driusan closed this Nov 27, 2020
@laemtl
Copy link
Contributor Author

laemtl commented Nov 27, 2020

@driusan Create timepoint was reactified and this PR fix the same issue as #7146, but for main and for the reactified version.

@driusan
Copy link
Collaborator

driusan commented Nov 30, 2020

I didn't notice that it's changing a different file name because of reactification so it won't get changed when the branch is pulled forward, this does need to be a separate PR afterall.

@driusan driusan reopened this Nov 30, 2020
@driusan driusan merged commit 4b139f9 into aces:main Dec 7, 2020
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
Fix a reindexing of the languages array which was causing a database insert error (key constraint failure on languageID).
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants