[instrument] insert JSON intrument fix #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
added
the
Bug
driusan
requested changes
Dec 1, 2020
ridz1208
requested changes
Dec 1, 2020
| @@ -35,7 +35,7 @@ abstract class NDB_BVL_Instrument extends NDB_Page | |||
| * JSON format from the "Data" column of the flag table, or | |||
| * from the traditional SQL tables. | |||
| */ | |||
| protected $jsonData = false; | |||
| public $jsonData = false; | |||
There was a problem hiding this comment.
why was this made public ? you can reach the value from outside using usesJSONdata() or a soemthing like that. I dont think this variable should be modifiable by external classes
There was a problem hiding this comment.
@ridz1208 Fixed! I missed this accessor. I agree that it's safer to rely on it. Should it be the same for other properties like table, which is public (despite stating it is private in the class doc)?
laemtl
force-pushed
the
2020-11-30-json-instrument-fix
branch
from
70de97f
to
5f32b95
Compare
laemtl
force-pushed
the
2020-11-30-json-instrument-fix
branch
from
5f32b95
to
76eef7d
Compare
ridz1208
approved these changes
Dec 2, 2020
driusan
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes minor warnings and the logic to populate an instrument with json_data === true.