Replace Center_name in mri_protocol with CenterID from psc

[vietdhoang]

Summary

From #646: Currently, when an mri_protocol is not being restricted for a specify Center_name, users enter either ZZZZ or AAAA and it is understood that an mri_protocol with Center_name ZZZZ or AAAA is valid for all centres' scans.

This PR fixes this 'hack' by replacing the Center_name field with CenterID from the psc table. CenterID is an integer and a unique indentifier for each center. When an mri_protocl is not restricted to a specific center, the default value is NULL (instead of ZZZZ/AAAA).

Testing instructions

It is recommended that everything should be tested using the RaisinBread dataset. To populate your database with RaisinBread data, run the script tools/raisinbread_refresh.php. WARNING: any previous data will be erased.

1. First, we will check if the SQL patch works. Source the new SQL patch:

source SQL/New_patches/2021-07-29_modify_center_name_in_mri_protocol.sql;

2. Verify that the Center_name field has been replaced by CenterID and that the default values (rows that used to contain AAAA or ZZZZ) are NULL.

SELECT * FROM mri_protocol;

3. Next, we will have to check if the changes made in 0000-00-00-schema.sql work. First, reset the RaisinBread dataset using tools/raisinbread_refresh.php. This command will have to be done on a different branch where 0000-00-00-schema.sql has not been changed yet. Verify that the refreshed mri_protocol table no longer has the CenterID field from step 2.
4. Next, switch to the branch containing all the changes made by this PR. Run the raisinbread_refresh.php again. This script will source the 0000-00-00-schema.sql file that has been changed.
5. Verify that the CenterID field has been added (step 2).

[cmadjar]

@kongtiaowang @ridz1208 @driusan we can't figure out why the tests are failing here, could you help @vietdhoang resolve the test issues? Thanks!

[ridz1208]

@cmadjar it seems like the mri violations module doesnt load at all. If it's not the case, @kongtiaowang could you debug the test ?

[cmadjar]

@driusan @kongtiaowang the test failure does not seem related to the changes in the PR. Could you help us figure out what is going on? Note, the PR has been rebased today.

[cmadjar]

HALLELUIA!!! This is passing the tests! Quick, @driusan merge before it does not pass the tests anymore, LOL.

Jokes aside, this one is now in your court. Thank you :).

[cmadjar]

@driusan I restarted the jobs. The only thing I changed in the last commit was the CHANGELOG so it does not make sense that the tests are suddenly failing since it passed the commit before...

[cmadjar]

@driusan passing the tests. Phew! Ready for you.