Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RaisinBread] Fixed Candidate DoB and Date_registered entries #8146

Merged
merged 3 commits into from Aug 30, 2022
Merged

[RaisinBread] Fixed Candidate DoB and Date_registered entries #8146

merged 3 commits into from Aug 30, 2022

Conversation

satvik-tha-god
Copy link
Contributor

Brief summary of changes

Changes entries with negative DATEDIFF > 9 months between DoB and Date_registered from candidate table in RaisinBread data

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Aug 3, 2022

@satvik-tha-god The build should be fixed now. Can you rebase this to make sure tests still pass?

@racostas racostas self-requested a review August 28, 2022 03:37
racostas
racostas approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas racostas added GSOC Google Summer of Code related Passed Manual Tests PR has undergone proper testing by at least one peer labels Aug 28, 2022
@driusan driusan merged commit 2278498 into aces:main Aug 30, 2022
@christinerogers
Copy link
Contributor

Thanks for these important fixes to our sample dataset @satvik-tha-god 👍

@ridz1208 ridz1208 added this to the 25.0.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racostas racostas racostas approved these changes

Assignees
No one assigned
Labels
GSOC Google Summer of Code related Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.

[RaisinBread] Improve the variance and diversity of the candidate data
5 participants
@satvik-tha-god @driusan @christinerogers @racostas @ridz1208