Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard/statistics] Reactification #8476

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Mar 23, 2023

Replaces #8261 (Rebased version)

@laemtl
Copy link
Contributor Author

laemtl commented Mar 23, 2023

@CamilleBeau If this passes the tests this will need to be retested since the rebase process might have introduced changes.

@laemtl laemtl force-pushed the dashboard_react_update branch 3 times, most recently from 2c6fb01 to b1d1a03 Compare March 23, 2023 16:23
@CamilleBeau
Copy link
Contributor

@laemtl Thank you Laetitia. I will re-test once the tests are all passing!

@laemtl laemtl force-pushed the dashboard_react_update branch 5 times, most recently from 4e95d2e to 556222c Compare March 24, 2023 04:34
Co-authored-by: laemtl <laetitia.fesselier@mail.mcgill.ca>
@driusan driusan merged commit 42ad5f3 into aces:main Mar 24, 2023
@driusan
Copy link
Collaborator

driusan commented Mar 24, 2023

merging since @CamilleBeau approved the other non-rebased one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants