Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[imaging_qc] Improve Error Message #8779

Merged
merged 13 commits into from
Aug 10, 2023
Merged

[imaging_qc] Improve Error Message #8779

merged 13 commits into from
Aug 10, 2023

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Jun 13, 2023 •
edited
Loading

Brief summary of changes

  • Changed the error message to be more specific

Testing instructions (if applicable)

  1. run alter table mri_parameter_form rename to mri_parameter_form2;
  2. Try to open Imaging>Imaging Quality Control
  3. See the new error message

Link(s) to related issue(s)

New error:
image

If there is an error caused by something else since mri_parameter_form exists:
image

@skarya22 skarya22 changed the base branch from main to 25.0-release June 13, 2023 17:01
@skarya22 skarya22 added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 13, 2023
@skarya22 skarya22 removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 19, 2023
@skarya22 skarya22 requested a review from driusan June 19, 2023 16:45
@skarya22 skarya22 removed their assignment Aug 10, 2023
@sruthymathew123 sruthymathew123 added the Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS label Aug 10, 2023
@sruthymathew123 sruthymathew123 self-assigned this Aug 10, 2023
@sruthymathew123
Copy link
Contributor

@driusan @skarya22 Tested this PR and pass the manual tests.
Screen Shot 2023-08-10 at 11 14 59 AM

@sruthymathew123 sruthymathew123 added the Passed Manual Tests PR has undergone proper testing by at least one peer label Aug 10, 2023
@driusan driusan merged commit d180ef6 into aces:25.0-release Aug 10, 2023
@ridz1208 ridz1208 added this to the 25.0.1 milestone Nov 9, 2023
kongtiaowang pushed a commit to kongtiaowang/Loris that referenced this pull request Nov 29, 2023
@skarya22 @kongtiaowang
[imaging_qc] Improve Error Message (aces#8779)
76f2161 
Improve error message when mri_parameter_form doesn't exist

Resolves aces#5325
@skarya22 skarya22 mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan Awaiting requested review from driusan

Assignees

@sruthymathew123 sruthymathew123

Labels
25.0.0 - Bugs Passed Manual Tests PR has undergone proper testing by at least one peer Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Milestone
25.0.1
Development

Successfully merging this pull request may close these issues.

Improve error message when mri_parameter_form doesn't exist
4 participants
@skarya22 @sruthymathew123 @driusan @ridz1208