Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrument List] Refresh on Stage Update #9040

Merged
merged 7 commits into from
Feb 13, 2024
Merged

[Instrument List] Refresh on Stage Update #9040

merged 7 commits into from
Feb 13, 2024

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Feb 2, 2024

Brief summary of changes

  • Refresh page when stage changes

Testing instructions (if applicable)

  1. Try changing the stage of a timepoint and see that the stage updates in the main page.
  2. See issue for a video demo

Link(s) to related issue(s)

racostas
racostas approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label Feb 5, 2024
@racostas
Copy link
Contributor

racostas commented Feb 5, 2024

@driusan, this one is ready to final review.

driusan
driusan requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comments

@skarya22 skarya22 requested a review from driusan February 8, 2024 14:50
@skarya22 skarya22 removed the Passed Manual Tests PR has undergone proper testing by at least one peer label Feb 8, 2024
racostas
racostas approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested. LGTM.

@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label Feb 9, 2024
@racostas
Copy link
Contributor

racostas commented Feb 9, 2024

looks good to me @driusan

@driusan driusan merged commit 778e616 into aces:main Feb 13, 2024
22 checks passed
@skarya22 skarya22 mentioned this pull request Feb 19, 2024
Closed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
@skarya22 skarya22 mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan requested changes

@racostas racostas racostas approved these changes

Assignees

@skarya22 skarya22

Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.

[instrument_list] Updating stage status doesn't show in Stage table
4 participants
@skarya22 @racostas @driusan @ridz1208