Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_tracker] null option assignee #9169

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

regisoc
Copy link
Contributor

@regisoc regisoc commented Mar 27, 2024

Brief summary of changes

This PR:

  • Forces an internal server error JSON response on db update error, which allows to actually see front-end swal error.
  • Bug fixes the "null" userID assignee that was the current user (i.e. added based on a composed string "full name (userid)").

Testing instructions (if applicable)

  1. Go to Report > issue tracker
  2. click on "new issue".
  3. assert no "null" user is in the "assignee" dropdown
  4. create new issue with some basic fileds.
  5. click inside the previously created issue inside the main issue tracker table.
  6. click on "assignee" dropdown.
  7. assert no "null" user is in the "assignee" dropdown.

Link(s) to related issue(s)

@driusan driusan self-assigned this Mar 27, 2024
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on my sandbox, looks like the null isn't there anymore.

@driusan driusan merged commit 8bbcfbc into aces:main Mar 27, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[issue_tracker] Null option in user assignees
3 participants