feat: ribbon component #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonid
reviewed
Dec 16, 2024
| * The alert type | ||
| */ | ||
| type: 'info' | 'success' | 'warning' | 'critical' | 'error' | ||
| type: 'info' | 'success' | 'warning' | 'critical' | 'danger' | 'neutral' |
Member
There was a problem hiding this comment.
You can use export type AcvAlertRibbonVariant = typeof ALERT_RIBBON_VARIANT[keyof typeof ALERT_RIBBON_VARIANT];
Or the same type from Alert component
leonid
requested changes
Dec 16, 2024
| * The alert type | ||
| */ | ||
| type: 'info' | 'success' | 'warning' | 'critical' | 'error' | ||
| type: 'info' | 'success' | 'warning' | 'critical' | 'danger' | 'neutral' |
| </template> | ||
|
|
||
| <style scoped> | ||
| <style lang="scss" scoped> |
Member
There was a problem hiding this comment.
we dont use scss in components styles
ildar-min
force-pushed
the
feat/ribbon
branch
5 times, most recently
from
ca0c61a to
c7d6ef8
Compare
leonid
reviewed
Dec 17, 2024
| * The alert type | ||
| */ | ||
| type: 'info' | 'success' | 'warning' | 'critical' | 'error' | ||
| type: keyof typeof TYPE |
Member
There was a problem hiding this comment.
i would rather create a separate typescript type to make it available in exported types later
| <script setup lang="ts"> | ||
| import type { AcvRibbonEvents, AcvRibbonLink, AcvRibbonProps, AcvRibbonSlots } from './ribbon.ts'; | ||
| import Alert from '@/components/alert/alert.vue'; | ||
| import Button from '@/components/button/button.vue'; |
Member
There was a problem hiding this comment.
Its better to use consistent names in imports ie AcvAlert, AcvButton
ildar-min
force-pushed
the
feat/ribbon
branch
from
c7d6ef8 to
e878870
Compare
leonid
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Implemented ribbon component