Skip to content

Conversation

WilcoFiers
Copy link
Member

There is definitely no reason why this inapplicable example should have a delayed redirect in it.

Need for Final Call: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Jun 3, 2021
@patrickhlauke
Copy link
Contributor

could even just replace that redirect meta with something like <meta charset="UTF-8"> if the idea is to show an inapplicable case where there is a meta, but not a viewport one. refresh starts to conjure up unrelated thoughts of "but does this fail some other SC like timing or pause/stop/hide or similar?")

@WilcoFiers WilcoFiers removed the Review Call 1 week Call for review for small changes label Jun 10, 2021
@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Jun 14, 2021
@WilcoFiers WilcoFiers requested a review from colabottles June 14, 2021 10:36
Copy link
Collaborator

@colabottles colabottles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not seen this "in the wild" or implemented as such for a very, very long time. Is it still even being used? I imagine it is on legacy sites or sites that are not maintained. I think a charset="UTF-8" is sufficient.

@WilcoFiers WilcoFiers merged commit eb047e0 into develop Jun 22, 2021
@WilcoFiers WilcoFiers deleted the WilcoFiers-patch-1 branch June 22, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants