Skip to content

Conversation

daniel-montalvo
Copy link
Collaborator

@daniel-montalvo daniel-montalvo commented Sep 16, 2025

The format now says that the test cases should be named examples, and it has a MUST on it, so we should do this before attempting to transition to REC.

Closes issue(s):

Need for Call for Review:
This will require a 1-week call for review (changes the name of one of the key sections of our rules).


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 3bffeb0
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/68d3efc407ef8e000897a81f
😎 Deploy Preview https://deploy-preview-2352--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo daniel-montalvo changed the title Changes 'test cases' to 'examples' as required by ACT Rules Format 1.1 Change 'test cases' to 'examples' as required by ACT Rules Format 1.1 Sep 16, 2025
@daniel-montalvo daniel-montalvo self-assigned this Sep 16, 2025
@daniel-montalvo daniel-montalvo marked this pull request as draft September 16, 2025 12:29
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Copy link
Collaborator

@kengdoj kengdoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions. Some are changes to path which I'm not sure of so please review.

daniel-montalvo and others added 10 commits September 23, 2025 17:38
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
@daniel-montalvo daniel-montalvo dismissed kengdoj’s stale review September 23, 2025 15:57

Thanks for picking these ones up @kengdoj

Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but I think we probably should do at least a 1-week call for review for this.

@daniel-montalvo daniel-montalvo added General for all rules Review Call 1 week Call for review for small changes labels Sep 24, 2025
@daniel-montalvo daniel-montalvo dismissed WilcoFiers’s stale review September 24, 2025 14:07

The review period has been updated.

/**
* Check if filename has `id` as a part of the name
*/
test('each testcase has a heading', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we also changing testcase (with no space) to example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-montalvo can you look at this. Discussed on the call, we can do this in a separate PR too if you prefer.

Copy link
Collaborator

@zlayaAvocado zlayaAvocado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one non blocking comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General for all rules Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all rules "Test cases" have been renamed to "examples"
7 participants