New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyton-version to setup PyPy output #365
Add pyton-version to setup PyPy output #365
Conversation
I think it'll be better to move such kind of logic here. |
Yes, it is done, |
@@ -52,6 +52,7 @@ export async function findPyPyVersion( | |||
core.exportVariable('pythonLocation', pythonLocation); | |||
core.addPath(pythonLocation); | |||
core.addPath(_binDir); | |||
core.setOutput('python-version', 'pypy' + resolvedPyPyVersion.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test we can add to make sure it doesn't regress again?
* upstream/main: (33 commits) Fix virtual-env toolcache links Updated @actions/cache (actions#382) ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379) Cache hit output (actions#373) Add pyton-version to setup PyPy output (actions#365) Rework pipenv caching test (actions#375) Update README.md to fix setup-python version in example (actions#368) dist fix (actions#367) Cache on ghes (actions#363) Update dist Use `\n` instead of `os.EOL` Update dist Initialise pyproject.toml Build and format Remove console.log Remove unused file Reduce test matrix Parse values from poetry Release Add more tests ...
Description:
During the migration from the legacy PyPy input the setting output "pyton-version" was omitted
Related issue:
link to the related issue
Test build
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true
confirmation the output is set:
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true#step:4:39
Check list: