Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyton-version to setup PyPy output #365

Merged
merged 4 commits into from Apr 4, 2022
Merged

Add pyton-version to setup PyPy output #365

merged 4 commits into from Apr 4, 2022

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Mar 31, 2022

Description:
During the migration from the legacy PyPy input the setting output "pyton-version" was omitted

Related issue:
link to the related issue

Test build
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true

confirmation the output is set:
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true#step:4:39

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame requested a review from as a code owner Mar 31, 2022
@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Mar 31, 2022

I think it'll be better to move such kind of logic here.

@vsafonkin vsafonkin self-requested a review Apr 1, 2022
@dsame
Copy link
Contributor Author

@dsame dsame commented Apr 2, 2022

I think it'll be better to move such kind of logic here.

Yes, it is done,
test build: https://github.com/akv-demo/setup-python-test/runs/5801619011?check_suite_focus=true

@@ -52,6 +52,7 @@ export async function findPyPyVersion(
core.exportVariable('pythonLocation', pythonLocation);
core.addPath(pythonLocation);
core.addPath(_binDir);
core.setOutput('python-version', 'pypy' + resolvedPyPyVersion.trim());
Copy link
Contributor

@brcrista brcrista Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we can add to make sure it doesn't regress again?

@brcrista brcrista merged commit 7933d5a into actions:main Apr 4, 2022
84 of 96 checks passed
@vsafonkin vsafonkin deleted the v-sedoli/fix-pypy-version.output branch Apr 4, 2022
adilosa added a commit to adilosa/setup-python that referenced this issue Apr 19, 2022
* upstream/main: (33 commits)
  Fix virtual-env toolcache links
  Updated @actions/cache (actions#382)
  ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379)
  Cache hit output (actions#373)
  Add pyton-version to setup PyPy output (actions#365)
  Rework pipenv caching test (actions#375)
  Update README.md to fix setup-python version  in example (actions#368)
  dist fix (actions#367)
  Cache on ghes (actions#363)
  Update dist
  Use `\n` instead of `os.EOL`
  Update dist
  Initialise pyproject.toml
  Build and format
  Remove console.log
  Remove unused file
  Reduce test matrix
  Parse values from poetry
  Release
  Add more tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants