Add pyton-version to setup PyPy output #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'll be better to move such kind of logic here. |
vsafonkin
approved these changes
Mar 31, 2022
Yes, it is done, |
brcrista
reviewed
Apr 4, 2022
| @@ -52,6 +52,7 @@ export async function findPyPyVersion( | |||
| core.exportVariable('pythonLocation', pythonLocation); | |||
| core.addPath(pythonLocation); | |||
| core.addPath(_binDir); | |||
| core.setOutput('python-version', 'pypy' + resolvedPyPyVersion.trim()); | |||
There was a problem hiding this comment.
Is there a test we can add to make sure it doesn't regress again?
brcrista
approved these changes
Apr 4, 2022
vsafonkin
approved these changes
Apr 4, 2022
2 tasks
adilosa
added a commit
to adilosa/setup-python
that referenced
this pull request
Apr 19, 2022
* upstream/main: (33 commits) Fix virtual-env toolcache links Updated @actions/cache (actions#382) ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379) Cache hit output (actions#373) Add pyton-version to setup PyPy output (actions#365) Rework pipenv caching test (actions#375) Update README.md to fix setup-python version in example (actions#368) dist fix (actions#367) Cache on ghes (actions#363) Update dist Use `\n` instead of `os.EOL` Update dist Initialise pyproject.toml Build and format Remove console.log Remove unused file Reduce test matrix Parse values from poetry Release Add more tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description:
During the migration from the legacy PyPy input the setting output "pyton-version" was omitted
Related issue:
link to the related issue
Test build
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true
confirmation the output is set:
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true#step:4:39
Check list: