New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax kaminari dependency for kaminari 1.0.0 #4722

Merged
merged 2 commits into from Jan 11, 2017

Conversation

Projects
None yet
3 participants
@sue445
Contributor

sue445 commented Jan 11, 2017

kaminari v1.0.0 is released!

It seems no problem at my environment. (Ruby 2.4.0, Rails 5.0.1)

@timoschilling

This comment has been minimized.

Show comment
Hide comment
@timoschilling

timoschilling Jan 11, 2017

Member

The tests are not working with ruby 1.9, while Kaminari 1.0 no longer supports RUby <2.0

We can merge this if kaminari/kaminari#847 is merged and released

Member

timoschilling commented Jan 11, 2017

The tests are not working with ruby 1.9, while Kaminari 1.0 no longer supports RUby <2.0

We can merge this if kaminari/kaminari#847 is merged and released

@sue445

This comment has been minimized.

Show comment
Hide comment
@sue445

sue445 Jan 11, 2017

Contributor

🙇

Contributor

sue445 commented Jan 11, 2017

🙇

@timoschilling

This comment has been minimized.

Show comment
Hide comment
@timoschilling

timoschilling Jan 11, 2017

Member

one other option is that we can set different kaminari versions in our Gemfile for Ruby 1.9 and >2

Member

timoschilling commented Jan 11, 2017

one other option is that we can set different kaminari versions in our Gemfile for Ruby 1.9 and >2

@sue445

This comment has been minimized.

Show comment
Hide comment
@sue445

sue445 Jan 11, 2017

Contributor

hmm...

I fixed that use kaminari 0.x when travis uses ruby 1.9.
5dca341

Contributor

sue445 commented Jan 11, 2017

hmm...

I fixed that use kaminari 0.x when travis uses ruby 1.9.
5dca341

@timoschilling timoschilling merged commit 5f8a099 into activeadmin:master Jan 11, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
hound No violations found. Woof!

@sue445 sue445 deleted the sue445:kaminari_v1.0.0 branch Jan 12, 2017

@varyonic

This comment has been minimized.

Show comment
Hide comment
@varyonic

varyonic Jan 12, 2017

Member

Does this resolve #4173 ?

Member

varyonic commented Jan 12, 2017

Does this resolve #4173 ?

@sue445

This comment has been minimized.

Show comment
Hide comment
@sue445

sue445 Jan 12, 2017

Contributor

No. This problem is not solved.

image

Contributor

sue445 commented Jan 12, 2017

No. This problem is not solved.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment