Skip to content

Conversation

brentru
Copy link
Member

@brentru brentru commented Jun 28, 2018

Addressing: #18

In particular break out connection attempt failed errors (non-zero RC in connect callback), and the disconnect errors (non-zero RC in disconnect callback) into explicit error types that inherit from a common error base. This way it's easier to catch errors like unexpected disconnects and retry connecting to the service.

Impl.: Broke out another error class for RC errors (MQTTERROR) in errors.py, made a list of errors (so we can add more into IO, #6-255 are unassigned), called in mqtt_client.py.

@brentru brentru requested review from abachman and jwcooper June 28, 2018 18:48
@brentru brentru merged commit 050523e into api-v2 Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant