Simulation interfaces: O3DE team feedback PR #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
zakmat
reviewed
Dec 17, 2024
Co-authored-by: Martin Pecka <peci1@seznam.cz> Co-authored-by: Steve Peters <computersthatmove@gmail.com>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> robot_namespace -> namespace Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: David V. Lu!! <davidvlu@gmail.com>
Co-authored-by: David V. Lu!! <davidvlu@gmail.com>
- wording change for stepping service - features message - comment documentation for USD and URDF formats - custom formats list field Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: David V. Lu!! <davidvlu@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
- Changed SpawnPose to NamedPose, added tags. - SpawnEntity interface substantially updated. - Some improved documentation, especially regarding spawning. - applied other code review comments Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Tully Foote <tully.foote@gmail.com>
- Result is now code-based and extendable. - Generic result message is defined with uint8 and string parts - Result codes extension is in place, with specific codes for services. - Entity message is removed as it is handled as string everywhere. - EntityInfo and GetEntityInfo is added, with tags and categories. - Filtering for tags and categories is added. - Review suggestions applied. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Co-authored-by: Martin Pecka <peci1@seznam.cz> Co-authored-by: David V. Lu!! <davidvlu@gmail.com>
- Updated min cmake version - Created EntityCategories to capture constants. - Extracted TagsFilter into a message, reused in GetNamedPoses. - Other minor changes Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
- Added Entity message, EntityWithState changed to just EntityState - Separated out EntityFilters - There are now both GetEntities and GetEntitiesStates services. - NamedPose bounds are now not included in GetNamedPoses, but instead there is a GetNamedPoseBounds service. - PoseBounds are now Bounds, and are used for Spawnables, Poses and Entities, and are more generic. - New interface GetEntityBounds along with feature type. - EntityFilters now include an overlap filter, a practical one. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
- Changed from string to Entity type for entity interfaces. - Added SimulationState SetSimulationState and GetSimulationState interfaces. - Clarified twist reference frame as suggested. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Michał Pełka <michal.pelka@robotec.ai>
Co-authored-by: David V. Lu!! <davidvlu@gmail.com>
- Entity message is removed as it was just a string. - Suggestions applied to usage of bounds. - Renaming of MultiStepSimulation to SimulateSteps. - Adjustments of SimulationFeatures to changes. - Multiple documentation clarifications / additions. Additionally, introduced TYPE_EMPTY for bounds for consistency. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: David V. Lu!! <davidvlu@gmail.com>
- Added SetEntityInfo to be enable setting of items such as tags. - EntityCategory is now self-contained. - Updated SimulationFeatures to reflect changes - Adjusted documentation in a few places. - Added 2 new sections to the README. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
- Documentation of relevant feature support flag per each interface. - Enumeration naming changed to TYPE_, CATEGORY_ etc. - Default to 1 for steps. - Other minor suggested docs changes. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Paweł Liberadzki <pawel.liberadzki@gmail.com>
Co-authored-by: Paweł Liberadzki <pawel.liberadzki@gmail.com>
adamdbrw
added a commit
that referenced
this pull request
Apr 17, 2025
Following ros-infrastructure/rep#410, this PR contains a first version of simulation interfaces. Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Martin Pecka <peci1@seznam.cz> Co-authored-by: Steve Peters <computersthatmove@gmail.com> Co-authored-by: David V. Lu!! <davidvlu@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Tully Foote <tully.foote@gmail.com> Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Paweł Liberadzki <pawel.liberadzki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR mirroring the base repo one for the sake of coordinated review from the O3DE team before making noise in the base one.