Disable cell navigation while editing, add column.editorOptions.onNavigation #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using tab during editing is quite common and I am not sure if we can completely disable it. Having an option to control the editing would be nice though |
nstepien
changed the title
amanmahajan7
reviewed
Nov 5, 2020
src/utils/columnUtils.ts
Outdated
| * By default, the following navigation keys are enabled while an editor is open, under specific conditions: | ||
| * - Tab: | ||
| * - The editor must be an <input>, a <textarea>, or a <select> element. | ||
| * - The editor element must be the only immmediate child of the editor container. |
There was a problem hiding this comment.
Would it break if input has a container element like a label?
div.rdg-editor-container > label > input
| @@ -722,6 +723,10 @@ function DataGrid<R, SR>({ | |||
| } | |||
|
|
|||
| function navigate(event: React.KeyboardEvent<HTMLDivElement>) { | |||
| if (selectedPosition.mode === 'EDIT') { | |||
| const onNavigation = columns[selectedPosition.idx].editorOptions?.onNavigation ?? onEditorNavigation; | |||
There was a problem hiding this comment.
We can probably add an example of custom onEditorNavigation like
- Navigate left if the cursor is at position 0
- Navigate right if the cursor is at position selection.length
amanmahajan7
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.