fix: correct tool name in list_creative_formats method #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed critical copy-paste bug where list_creative_formats() was calling
adapter.call_tool("update_media_buy", ...) instead of the correct
"list_creative_formats" tool name.
Bug Impact:
- Method was completely non-functional, calling wrong tool
- Activity logs showed incorrect task_type
- Webhooks and tracking would fail for this method
Root Cause:
- Copy-paste error from method template
- Over-mocked tests didn't verify tool name argument
- Tests passed because mocks returned success regardless of tool name
Test Improvements:
- Added parameterized test verifying ALL methods call correct tool names
- Fixed test_get_products to verify tool name argument
- Fixed test_multi_agent_parallel_execution to actually test execution
- Enhanced protocol tests to verify HTTP/MCP request details
- Removed non-functional stub tests from test_cli.py
All 68 tests now pass, including the new test that would have caught
this bug immediately.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed critical copy-paste bug where
list_creative_formats()was callingadapter.call_tool("update_media_buy", ...)instead of the correct"list_creative_formats"tool name.Test Improvements
All 68 tests pass.
🤖 Generated with Claude Code