fix: improve MCP adapter cleanup on connection failures #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract duplicate cleanup logic into _cleanup_failed_connection() method to follow DRY principle. Properly handle anyio task group errors without masking original connection failures. Errors like "Attempted to exit cancel scope in a different task" are now logged at debug level rather than raised, allowing the actual connection error to propagate correctly. Also update TaskResult config to use Pydantic v2 ConfigDict pattern, eliminating deprecation warnings. Add comprehensive test coverage for connection failure scenarios and async context manager usage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Demonstrate the recommended async context manager pattern for proper connection cleanup. Update Quick Start example to use context manager, ensuring new users adopt best practices from the start. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Address code review feedback: - Update examples/ to use async context managers (critical fix) - Add 'Why use context managers?' explanation with clear benefits - Add complete imports to all code examples for copy-paste usability - Expand manual cleanup section with use cases and guidance - Improve comments to clarify what gets cleaned up All examples now consistently demonstrate the recommended pattern for proper resource cleanup, making it easier for new users to adopt best practices. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Pull in batch preview API changes from #18 before merging cleanup improvements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Split long warning message across multiple lines to comply with 100 character line limit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract duplicate cleanup logic and improve error handling during MCP adapter shutdown. Properly handle anyio task group errors without masking original connection failures. Errors like "Attempted to exit cancel scope in a different task" are now logged at debug level rather than raised.
Refactor async resource management to follow DRY principles and update TaskResult to Pydantic v2 ConfigDict pattern, eliminating deprecation warnings.
What Changed
_cleanup_failed_connection()method to eliminate code duplicationTests
All 105 tests pass with no warnings. New tests cover connection failure cleanup, async context manager usage, and cancellation scenarios.
🤖 Generated with Claude Code