feat: Add is_fixed discriminator to pricing types #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced updated AdCP schemas from upstream that add the is_fixed discriminator field to pricing option types. This discriminator distinguishes between fixed-rate and auction-based pricing options. Changes: - Synced 8 updated pricing schema files from upstream - Regenerated all Python types from schemas - Added is_fixed discriminator to pricing option types: - CpcPricingOption (is_fixed=True) - CpcvPricingOption (is_fixed=True) - CpmFixedRatePricingOption (is_fixed=True) - CpmAuctionPricingOption (is_fixed=False) - CppPricingOption (is_fixed varies) - CpvPricingOption (is_fixed varies) - VcpmFixedRatePricingOption (is_fixed=True) - VcpmAuctionPricingOption (is_fixed=False) - FlatRatePricingOption (is_fixed=True) The pricing types already have semantic names, so no new type aliases were needed. All 258 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive documentation for: - Using uv for package management (uv sync, uv run) - Schema update workflow (sync → generate → test → review) - When to use venv vs system python for different scripts - Pricing type discriminators (is_fixed field) This captures learnings from the pricing discriminator update to help future development work go more smoothly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
changed the title
bokelley
added a commit
that referenced
this pull request
Nov 18, 2025
* feat: Add is_fixed discriminator to pricing types Synced updated AdCP schemas from upstream that add the is_fixed discriminator field to pricing option types. This discriminator distinguishes between fixed-rate and auction-based pricing options. Changes: - Synced 8 updated pricing schema files from upstream - Regenerated all Python types from schemas - Added is_fixed discriminator to pricing option types: - CpcPricingOption (is_fixed=True) - CpcvPricingOption (is_fixed=True) - CpmFixedRatePricingOption (is_fixed=True) - CpmAuctionPricingOption (is_fixed=False) - CppPricingOption (is_fixed varies) - CpvPricingOption (is_fixed varies) - VcpmFixedRatePricingOption (is_fixed=True) - VcpmAuctionPricingOption (is_fixed=False) - FlatRatePricingOption (is_fixed=True) The pricing types already have semantic names, so no new type aliases were needed. All 258 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: Add development workflow and uv usage to CLAUDE.md Added comprehensive documentation for: - Using uv for package management (uv sync, uv run) - Schema update workflow (sync → generate → test → review) - When to use venv vs system python for different scripts - Pricing type discriminators (is_fixed field) This captures learnings from the pricing discriminator update to help future development work go more smoothly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is_fixedfield to pricing optionsTest plan