fix: resolve Package type name collision with semantic aliases #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AdCP schemas define two different types both named "Package": - Full Package (package.json): Complete operational package with 12 fields - Created Package (create-media-buy-response.json): Minimal reference with 2 fields The code generator's "first wins" collision handling exported the response type, shadowing the domain model. This fix adds semantic aliases: - Package: The canonical full domain model (for MediaBuy, updates, etc.) - CreatedPackageReference: Minimal response type (for CreateMediaBuy responses) Imports Package directly from package.py module to bypass consolidation collision. Includes 7 comprehensive tests validating field structure and usage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed ruff linting issues that were causing CI failures: - Auto-fixed import block sorting in multiple test files - Split long assert messages across multiple lines - Shortened docstrings to fit 100-character limit All 282 tests still passing locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves type name collision where two different Package types are both exported as "Package":
The code generator's collision handling exported the wrong one. This fix adds semantic aliases for clarity.
Changes
Package: Canonical alias for the full domain model (used in MediaBuy, updates, etc.)CreatedPackageReference: New alias for the minimal response type (used in CreateMediaBuySuccessResponse)stable.pyto import Package directly from package.py module to bypass collisionTest Results
All 18 type alias tests passing, including new Package-specific tests validating: