You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed
Sync no longer slows down as the warehouse grows. The full-text triggers
located a row's index entry with DELETE ... WHERE <key> = ... on an
UNINDEXED FTS5 column, which scans the whole FTS table, so every upsert of a
PR, issue or comment cost a full scan. At 259k issue comments one sync all
ran past launchd's two-hour limit. Migration 8 rebuilds the four FTS tables
keyed by the source rowid, makes the triggers delete by rowid, and skips the
update trigger when no indexed column changed. On an 8.5 GB warehouse a
comment upsert now takes about 8 ms, and the one-time rebuild took 6m49s.
The rebuild runs when the first command opens the warehouse after the
upgrade, so expect that first sync or search to take minutes on a large
warehouse.