Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to Main for 4.2.0 release #976

Merged
merged 49 commits into from
Oct 31, 2023
Merged

Staging to Main for 4.2.0 release #976

merged 49 commits into from
Oct 31, 2023

Conversation

cdhoffmann
Copy link
Contributor

Staging to Main for 4.2.0 release which includes:

  • New storage service - Backed by File System instead of UserDefaults
  • Migrates existing data from UserDefaults to new File System

@cdhoffmann
Get objects working somewhat.
3248441
@cdhoffmann
Finish functional tests for data store
11551f6
@cdhoffmann
fix more broken tests, add utility for clearing new storage
d240fd4
@cdhoffmann
tests passing
c1fd15a
@cdhoffmann
add threading tests
8fe157a
@cdhoffmann
swift format
2e8b8c8
@cdhoffmann
clear storage files in setup
878b394
@cdhoffmann
clear storage files
b570e5a
@cdhoffmann
reset service in functional test
f485416
@cdhoffmann
make file writing sync instead of async
9484426
@cdhoffmann
Protect against traversal in base url for storage service
2ab72e8
@cdhoffmann
put write in do catch for error handling
aa39b2c
@cdhoffmann
make filesystem class vars private
15a7731
@cdhoffmann
remove extra private function, clean up a little
f046a86
@cdhoffmann
rename userdefault test to filesystem test, will keep userdefault cla…
3e6fbd3 
…ss for migration but remove post migration
@cdhoffmann
Update IDETemplateMacros.plist
0732dae
@cdhoffmann
move file from test app directory, no idea how it got there. Update t…
1a431ea 
…o block comments
@cdhoffmann
combine utility
95c178e
@cdhoffmann
test failing intermittently because cache is already clear and throwi…
b31ce16 
…ng when clearing something which doesn't exist.
@cdhoffmann
make set logic simpler
6076d00
@cdhoffmann
Add performance tests
8cfbdc0
@cdhoffmann
add setAppGroup for testing, and add some docs
361391b
@cdhoffmann
swift format
4ca4e57
@cdhoffmann
make writing async, fix breaking tests by resetting kv service betwee…
94c78bc 
…n tests. etc.
@cdhoffmann
swift format
8ea84f6
@cdhoffmann
rename queue
fef2c3a
@cdhoffmann
add keys for userdefault migration
0040df0
@cdhoffmann
change error to warnings, and include more logs
1546b6f
@cdhoffmann
Merge pull request #966 from cdhoffmann/swapDataStore
909434e 
[MOB-19274][MOB-15354] Use Disk for Storage Services
@cdhoffmann
migration tests progress
02b8f45
cdhoffmann and others added 19 commits September 21, 2023 14:00
@cdhoffmann
finish migration tests
8fc8ef5
@cdhoffmann
add dependency for lifecycle and identity to core tests target for mi…
beacc82 
…gration
@praveek
Modify cache to not read file modification date
d161761
@praveek
Fix intermittent test failures
258e3c5
@cdhoffmann
Update needToMigrate logic to use new key, and update logs
85f7e64
@cdhoffmann
change key to specify the userdefault migration is complete
135f157
@cdhoffmann
Merge pull request #968 from cdhoffmann/migration
b431e5a 
[MOB-19513] Migration logic
@praveek
Fix logs
d9101d9
@praveek
Merge branch 'migrateOffUserDefaults' of https://github.com/adobe/aep…
a9c689f 
…sdk-core-ios into migrateOffUserDefaults
@praveek
Merge pull request #969 from praveek/migrateOffUserDefaults
0fe0e1e
@cdhoffmann
Add attribute for filesystem fileprotection set to none
f8ede5f
@cdhoffmann
Merge pull request #971 from cdhoffmann/migration
d3a5fe1 
Add attribute for fileprotection
@cdhoffmann
Updating versions to 4.2.0.
905bb1f
@cdhoffmann
Merge pull request #973 from adobe/version-4.2.0-update
d0d7505 
Updating versions to 4.2.0
@cdhoffmann
Merge pull request #972 from adobe/migrateOffUserDefaults
9dad765 
Migrate off UserDefaults for local storage
@cdhoffmann
Fix encoded data in migration
3a4d237
@cdhoffmann
remove setAppGroup to avoid issues when testing between main and dev …
bbfb306 
…branch.
@cdhoffmann
Merge pull request #974 from cdhoffmann/fixEncodedDataMigration
47e9199 
[MOB-19790] Fix encoded data in migration
@cdhoffmann
Merge pull request #975 from adobe/dev-v4.2.0
9ac82b7 
Dev v4.2.0 to Staging
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #976 (9ac82b7) into main (8c2ed45) will decrease coverage by 0.28%.
Report is 1 commits behind head on main.
The diff coverage is 91.92%.

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   90.10%   89.82%   -0.28%     
==========================================
  Files         130      133       +3     
  Lines        8161     8338     +177     
==========================================
+ Hits         7353     7489     +136     
- Misses        808      849      +41

@cdhoffmann cdhoffmann merged commit da278f9 into main Oct 31, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveek praveek praveek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdhoffmann @praveek