Skip to content

Conversation

namArora3112
Copy link
Collaborator

@namArora3112 namArora3112 commented Feb 20, 2025

Description

Screenshot
image
image

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cacheung
Copy link
Contributor

We should add this piece of info to Optimize readme as well
https://github.com/adobe/aepsdk-react-native/tree/main/packages/optimize

You can link to this Main readme, but if the user reading the Optimize Readme first, they will know what to look for.

@cacheung
Copy link
Contributor

cacheung commented May 8, 2025

We should add this piece of info to Optimize readme as well https://github.com/adobe/aepsdk-react-native/tree/main/packages/optimize

You can link to this Main readme, but if the user reading the Optimize Readme first, they will know what to look for.

Do you think we should have this piece of info in the Optimize readme too?

@namArora3112 namArora3112 changed the base branch from main to staging May 8, 2025 07:27
@namArora3112
Copy link
Collaborator Author

We should add this piece of info to Optimize readme as well https://github.com/adobe/aepsdk-react-native/tree/main/packages/optimize
You can link to this Main readme, but if the user reading the Optimize Readme first, they will know what to look for.

Do you think we should have this piece of info in the Optimize readme too?

I have added only note part or should we also add trouble shooting section too?
PS: Currently we dont have any troubleshooting section for optimize

@cacheung
Copy link
Contributor

cacheung commented May 8, 2025

We should add this piece of info to Optimize readme as well https://github.com/adobe/aepsdk-react-native/tree/main/packages/optimize
You can link to this Main readme, but if the user reading the Optimize Readme first, they will know what to look for.

Do you think we should have this piece of info in the Optimize readme too?

I have added only note part or should we also add trouble shooting section too? PS: Currently we dont have any troubleshooting section for optimize

No need to add troubleshooting section in the Optimize readme.

@namArora3112 namArora3112 merged commit a32e9bd into staging May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants