[Messaging] typecast Messaging Proposition for getPropositionsForSurface API #534
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishita-gambhir-adobe
requested review from
dsoffiantini,
namArora3112 and
cacheung
dsoffiantini
approved these changes
Sep 24, 2025
cacheung
reviewed
Sep 25, 2025
|
|
||
| for (const surface of SURFACES) { | ||
| const propositions = messages[surface] || []; | ||
|
|
There was a problem hiding this comment.
For the line 225 "When using getPropositionsForSurfaces, the returned objects can be wrapped with MessagingProposition..."
We can change to "When using getPropositionsForSurfaces, the returned objects are already MessagingProposition instances with typed items and convenient tracking via PropositionItem.track(...). "
cacheung
approved these changes
Sep 25, 2025
cacheung
pushed a commit
to cacheung/aepsdk-react-native
that referenced
this pull request
Sep 28, 2025
…ace API (adobe#534) * typecast Messaging Proposition * update README * update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: