Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

czech translation - sprint 21 #3150

Merged
merged 2 commits into from Mar 29, 2013
Merged

czech translation - sprint 21 #3150

merged 2 commits into from Mar 29, 2013

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2013

updated new strings

updated new strings
@jasonsanjose
Copy link
Member

Thanks @kvarel for signing the CLA. I closed your prior pull #2881.

Unfortunately we still haven't had any help finding someone to peer review your translation. I'll post again to the group but since you are more likely to know more czech speakers than we do, it may help for you to find your own peer reviewer.

@hansek
Copy link

hansek commented Mar 20, 2013

Translation looks good and correct from my point of view ;)

👍


// Application error strings
"ERROR_IN_BROWSER_TITLE" : "Ouha! {APP_NAME} ještě neběží v prohlížeči.",
"ERROR_IN_BROWSER" : "{APP_NAME} je vytvořen v HTML, ale nyní pracuje jako desktopová aplikace, takže ji můžete použít pro úpravu lokálních souborů.Prosím, použijte shell aplikace v <b>github.com/adobe/brackets-shell</b> repo pro spuštění {APP_NAME}.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after period souborů.Prosím

@jasonsanjose
Copy link
Member

@hansek @kvarel I noticed that some of the command names did not have each word capitalized. Is that expected for czech? For example Přejít na funkci. In English and other languages, each word would be capitalized.

@kvarel for this translation to be complete, you need to add the language to src/nls/strings.js as you did here #2892. I'm not sure if you're new to git, but each of your changes have been submitted as separate pull requests in separate branches. You can add commits to a branch without having to create a separate pull request for a new branch. For example, on this branch patch-5:

cd <path to>/brackets
git checkout patch-5
# make edits to src/nls/strings.js and src/nls/cs/strings.js
git add src/nls/strings.js
git add src/nls/cs/strings.js
git commit -m "add czech language and fix missing space"
git push origin patch-5

Let us know if you need any help. We appreciate your effort and want to merge your contribution as soon as possible.

@hansek
Copy link

hansek commented Mar 21, 2013

@jasonsanjose Yeah, this is normal for Czech, in Czech sentences or in word sets is only first letter capitalized.

@ghost
Copy link
Author

ghost commented Mar 22, 2013

yeah, this is my first time using git. sorry for rookie mistakes.

@jasonsanjose
Copy link
Member

No problem. Thanks for not giving up on it. :)

@ghost
Copy link
Author

ghost commented Mar 28, 2013

added tranlastion for sprint 22. also opened getting started page i closed by mistake.

@jasonsanjose
Copy link
Member

@hansek are you up to do another review pass with @kvarel's latest change?

@hansek
Copy link

hansek commented Mar 29, 2013

@jasonsanjose Of course, I have read content of new commit and It looks correct! 👍

Thanks @kvarel

@jasonsanjose
Copy link
Member

I'm going to merge this now and fix some remaining issues:

  • rename src/nls/cs to src/nls/cs/strings.json
  • add cs language to src/nls/strings.js

jasonsanjose added a commit that referenced this pull request Mar 29, 2013
czech translation - sprint 21
@jasonsanjose jasonsanjose merged commit ebab357 into adobe:master Mar 29, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants