This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixes bug #7667: Keyboard shortcut overlap with Chrome #8076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed shortcut for reloading without extensions to Opt-Shift-R and created a browserForceReload function that is triggered by Cmd-Shift-R. Changes to src/nls/root/strings.js will need to be localized for other languages as well.
|
Related to #8100 Ctrl+Alt v.s. AltGr conflict |
|
This should resolve Issue #7667 |
|
Thanks for the pull request! (Triage complete... ready for review) |
|
Thanks @dangoor! Looking forward to working more on Brackets. |
|
@lkcampbell points out that #8080 is fixing the same problem |
|
So will this be merged, or? |
|
@loganallenc That's ultimately up to whoever reviews this. They'll take a look at both and decide if it makes sense to go with one or the other... |
|
@loganallenc Thanks for this PR, but I think #8080 is a little closer to where we want to end up (keeps the command in LiveDevelopment, maps it to ctrl-Shift-R). The two pull requests are quite similar, and I appreciate you sending this our way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed shortcut for reloading without extensions to Opt-Shift-R and
created a browserForceReload function that is triggered by Cmd-Shift-R.
Changes to src/nls/root/strings.js will need to be localized for other
languages as well.