-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ComboBox refactoring #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ComboBox refactoring #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
…SelectedKey does not match
Build successful! 🎉 |
iOS 14 moves real DOM focus even with aria-activedescendant otherwise
Not when using a screen reader
And do not close when viewport scrolls while resizing due to keyboard appearing
…o combobox-stuff # Conflicts: # packages/@react-aria/listbox/package.json
Build successful! 🎉 |
Build successful! 🎉 |
dannify
approved these changes
Nov 6, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputValue
andselectedKey
don't control each other, which was kinda confusing. Instead they are controlled independently.useFilter
hook that provides locale sensitivestartsWith
,endsWith
, andcontains
functions to be used as custom filters. Theitems
prop now controls results and won't be filtered by default. The default filter is used whendefaultItems
or static children are used.onFilter
has been removed.onCustomValue
because it was confusing when it would be fired.onInputChange
should be enough here.Tab
key). It was weird to hover over an item and then click outside and it selected that option.aria-hidden
to all elements except both the input and the popover when open. Before the input wasn't accessible while the popover was open because it was hidden. This made it impossible for especially touch screen readers to use. This required crawling the DOM rather than relying on React context since both elements are not in the same subtree. Fixes ComboBox input is aria-hidden while popover is open #1093. Closes Popover should allow isModal={false} for ComboBox #1025.