fix(#1271): tabpanel should be labelled by the Picker button element when Tabs are collapsed #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment when Tabs are collapsed The aria-labelledby attribute on the tabpanel should be updated to refer to the Picker rather than the current tab, which is no longer in the DOM.
majornista
requested review from
dannify,
devongovett and
snowystinger
as code owners
LFDanLu
reviewed
Nov 14, 2020
|
|
||
| // When the tabs are collapsed, the tabPanel should be labelled by the Picker button element. | ||
| let collapsibleTabListId = useId(); | ||
| if (collapse) { |
There was a problem hiding this comment.
Tested in the orientation flip story and the collapse id aria-labelledby remained when the orientation flipped. Its a bit of a non-sensical example but you could fix it by adding a check here on orientation !== 'vertical' as well
dannify
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aria-labelledby attribute on the tabpanel should be updated to refer to the Picker rather than the current tab, which is no longer in the DOM.
Closes #1271
✅ Pull Request Checklist:
📝 Test Instructions:
role="tabpanel"in the Web Inspectoraria-labelledbyattribute points to the Picker button element.aria-labelledbyattribute points to the selected Tab.🧢 Your Project:
Adobe/Accessibility