Skip to content

Conversation

tomsontom
Copy link
Contributor

Closes #1229

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Run the new story book sample

🧢 Your Project:

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit 50b2ffb into adobe:main Dec 2, 2020
@tomsontom
Copy link
Contributor Author

May I ask why those changes have not been included in the release that was done on December 22nd?

@snowystinger
Copy link
Member

Hey, we didn't have enough time to do a complete testing of the release and we were focused on getting Slider out. This will be in our next release.

@tomsontom
Copy link
Contributor Author

ok - so how does one know if a fix is getting released? As you don't assign PRs nor Issues to Milestones I thought if it is merged into main it is going to part of the next release. Where/How do you track that controls who have changes are not yet released (including their prerequsits eg Picker needs a new version of utils)?

@snowystinger
Copy link
Member

Normally things merged to main will be in the next release. This was a special case because we didn’t have time for a full testing of the changes beyond the release of Slider because of the holiday period

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support autofocus on Picker
3 participants