Making linter add ^ to version when adding missing deps #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Dec 5, 2020
|
If it's an alpha/beta/rc, it should not use a caret range, it should be fixed. This is because we allow breaking changes but technically semver sees later prereleases as compatible. |
|
@devongovett Ah, thanks for the explanation, will fix so it detects the alpha/beta/rc when deciding whether or not to add a caret. |
snowystinger
reviewed
Dec 8, 2020
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Dec 8, 2020
|
Sorry for the conflicts |
…ixing_lint_import
snowystinger
approved these changes
Jan 4, 2021
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: