Skip to content

Updating tooltip width to match updated Spectrum value #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

Updating tooltip width to match updated Spectrum value #1451

merged 1 commit into from
Jan 14, 2021

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Jan 8, 2021

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ktabors
ktabors approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannify dannify merged commit c0626a1 into main Jan 14, 2021
@dannify dannify deleted the update_tooltip_max_width branch January 14, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors approved these changes

@snowystinger snowystinger snowystinger approved these changes

@dannify dannify dannify approved these changes

@devongovett devongovett Awaiting requested review from devongovett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LFDanLu @adobe-bot @ktabors @snowystinger @dannify