fix(#1316) Disabled keys not passing isDisable prop to item #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvanip
requested review from
dannify,
devongovett and
snowystinger
as code owners
razvanip
changed the title
LFDanLu
reviewed
Jan 25, 2021
| @@ -128,7 +128,7 @@ import {mergeProps} from '@react-aria/utils'; | |||
|
|
|||
| function Menu(props) { | |||
| // Create state based on the incoming props | |||
| let state = useTreeState({...props, selectionMode: 'none'}); | |||
| let state = useTreeState({...props, disabledKeys:['one'], selectionMode: 'none'}); | |||
There was a problem hiding this comment.
Just a small suggestion: I think this disabledKeys should be passed in as one of the Menu props like so
<Menu onAction={alert} aria-label="Actions" disabledKeys={["one"]}>
<Item key="one">One</Item>
<Item key="two">Two</Item>
<Item key="three">Three</Item>
</Menu>
There was a problem hiding this comment.
yeah, better will change it.
razvanip
commented
Jan 26, 2021
| let {menuItemProps} = useMenuItem({ | ||
| key: item.key, | ||
| isDisabled: item.isDisabled, | ||
| isDisabled: isDisabled, |
There was a problem hiding this comment.
keep isDisabled: isDisabled or go for shorthand just isDisabled ?
LFDanLu
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1316
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: