Numberfield fixes: remove aria-roledescription on iOS and replace hyphen with minus sign #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2021 13:23
So that the `required` state will announce, we ignore `aria-roledescription` on iOS. The input will announce as a simple text field.
…ion announcement So that VoiceOver will negative values consistently for currency or percent.
majornista
requested review from
dannify,
devongovett and
snowystinger
as code owners
added 2 commits
January 29, 2021 14:12
devongovett
approved these changes
Feb 1, 2021
dannify
pushed a commit
that referenced
this pull request
Feb 1, 2021
* Fix double border between input and buttons * Fix disabled focus and hover states for stepper buttons * Update stepper disabled state as you type * Adjust behavior of step to match slider and native number input * Allow incrementing/decrementing values that are near the min/max step value * Replace "spin button number field" with just "number field" * Improve focus behavior for stepper buttons * Fix forward delete of plusSign * Fix typing minus sign in some locales * making focused invalid numberfield stay red * Fix issue where we couldn't type a negative number * giving proper padding right to valid/invalid/loadable quiet textfields moved the styles so they are more specific than the isQuiet padding right styles * fixing numberfield quiet mobile stepper button active styles * Implement fallback support for reverting invalid composition events For browsers that don't support input events level 2 * Fix typing symbols from non-default numbering systems e.g. latin decimal point in arabic * Support normal negative numbers in accounting format * Remove horizontal scrolling as an incr/decr method * fix react 17 * Make active state go around full component rather than just input on touch * Set inputMode according to the OS * Fix sign display polyfill with number parser in Safari * Numberfield fixes: remove aria-roledescription on iOS and replace hyphen with minus sign (#1517) * Slight cleanup and add comment about minus sign Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Daniel <dlu@livefyre.com> Co-authored-by: Michael Jordan <mijordan@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1509 and #1486
✅ Pull Request Checklist:
📝 Test Instructions:
On an iOS device:
aria-roledescriptionwhere therequiredstate is not announced.In Safari on macOS:
🧢 Your Project:
Adobe/Accessibility