Toast container #153
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import {classNames} from '@react-spectrum/utils'; | ||
| import React, {ReactElement} from 'react'; | ||
| import {Toast} from './'; | ||
| import toastContainerStyles from './toastContainer.css'; | ||
| import {ToastStateBase} from '@react-types/toast'; | ||
|
|
||
| interface ToastProviderProps { | ||
| toasts?: ToastStateBase[], | ||
| } | ||
|
|
||
| export function ToastContainer(props: ToastProviderProps): ReactElement { | ||
| let renderToasts = () => props.toasts.map((toast) => | ||
| (<Toast {...toast.props}>{toast.content}</Toast>) | ||
| ); | ||
|
|
||
| return ( | ||
| <div className={classNames(toastContainerStyles, 'react-spectrum-ToastContainer')}> | ||
| {renderToasts()} | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import React, {ReactElement, ReactNode, useContext} from 'react'; | ||
| import {ToastContainer} from './'; | ||
| import {ToastOptions, ToastStateBase} from '@react-types/toast'; | ||
| import {useProviderProps} from '@react-spectrum/provider'; | ||
| import {useToastState} from '@react-stately/toast'; | ||
|
|
||
| interface ToastContextProps { | ||
| setToasts?: (any) => void, | ||
| toasts?: ToastStateBase[], | ||
| positive?: (content: ReactNode, options: ToastOptions) => void, | ||
| negative?: (content: ReactNode, options: ToastOptions) => void, | ||
| neutral?: (content: ReactNode, options: ToastOptions) => void, | ||
| info?: (content: ReactNode, options: ToastOptions) => void | ||
| } | ||
|
|
||
| interface ToastProviderProps { | ||
| children: ReactNode | ||
| } | ||
|
|
||
| export const ToastContext = React.createContext<ToastContextProps | null>(null); | ||
|
There was a problem hiding this comment. @snowystinger do you want this context to be it's own file? There was a problem hiding this comment. I don't particularly care, I had hoped originally that it would help with the circular dep, but since it doesn't affect it, you can leave it in here much like the Provider does |
||
|
|
||
| export function useToastProvider() { | ||
| return useContext(ToastContext); | ||
| } | ||
|
|
||
| export function ToastProvider(props: ToastProviderProps): ReactElement { | ||
| let {onAdd, toasts} = useToastState(); | ||
| let { | ||
| children | ||
| } = useProviderProps(props); | ||
|
|
||
| let contextValue = { | ||
|
There was a problem hiding this comment. how does someone add their own toast completely? is that not something we're going to support? There was a problem hiding this comment. Now sure what you mean? I believe we are only allowing them to use the functions from the context. There was a problem hiding this comment. in v2 people could use https://git.corp.adobe.com/React/react-spectrum-v2/blob/master/src/Toast/js/ToastContainer.js#L146 in addition to the predefined ones There was a problem hiding this comment. No, the Toast component is no longer public. |
||
| neutral: (content: ReactNode, options: ToastOptions = {}) => { | ||
| onAdd(content, options); | ||
LFDanLu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| positive: (content: ReactNode, options: ToastOptions = {}) => { | ||
| onAdd(content, {...options, variant: 'positive'}); | ||
| }, | ||
| negative: (content: ReactNode, options: ToastOptions = {}) => { | ||
| onAdd(content, {...options, variant: 'negative'}); | ||
| }, | ||
| info: (content: ReactNode, options: ToastOptions = {}) => { | ||
| onAdd(content, {...options, variant: 'info'}); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <ToastContext.Provider value={contextValue}> | ||
| <ToastContainer toasts={toasts} /> | ||
| {children} | ||
| </ToastContext.Provider> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| export * from './Toast'; | ||
| export * from './ToastContainer'; | ||
| export * from './ToastProvider'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| .react-spectrum-ToastContainer { | ||
| position: fixed; | ||
| top: unset; | ||
| bottom: 0; | ||
| inset-inline-start: 0; | ||
| inset-inline-end: 0; | ||
| z-index: 100050; /* above modals */ | ||
| display: flex; | ||
| flex-direction: column-reverse; | ||
| align-items: center; | ||
| pointer-events: none; | ||
|
|
||
| .spectrum-Toast { | ||
| margin: 8px; | ||
| pointer-events: all; | ||
| } | ||
| } | ||
| .react-spectrum-ToastContainer--top { | ||
| top: 0; | ||
| flex-direction: column; | ||
| bottom: unset; | ||
| } | ||
| .react-spectrum-ToastContainer--bottom { | ||
| flex-direction: column-reverse; | ||
| bottom: 0; | ||
| } | ||
| .react-spectrum-ToastContainer--left { | ||
| align-items: flex-start; | ||
| } | ||
| .react-spectrum-ToastContainer--center { | ||
| align-items: center; | ||
| } | ||
| .react-spectrum-ToastContainer--right { | ||
| align-items: flex-end; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that a ToastProvider renders its own ToastContainer, will this be a problem if someone launches a toast from inside a form that has a Provider wrapping it for setting isQuiet?
There'd then be two ToastContainers on the page I think?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devongovett Can you remind me what the desired functionality is? Is it that toasts only render into the topmost provider or that a toast renders into whichever provider it is in? I can't recall, I think v2 was more like the first, but you wanted v3 to do the second option.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to add a followup to create a story and test for this. The goal will be all toasts show up in the top provider. https://jira.corp.adobe.com/browse/RSP-1491