RSP-1307 Define Accessibility spec for Autocomplete #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! View the storybook |
|
Build successful! View the storybook |
|
Build successful! View the storybook |
dannify
approved these changes
Apr 8, 2020
|
Build successful! 🎉 |
devongovett
added a commit
that referenced
this pull request
Jul 25, 2024
* upgrade assistant initial commit * lint * support specifying a subset of components to upgrade * use file name for filtering * cleanup * include default codemods * update components args * add ts-node * fix binary loading * fix __dirname and exit * fix jscodeshift paths to default to all * fix ts build * cleanup rules * cleanup * add readme * configure tests to run * update jscodeshift usage * add UPGRADE.md * update UPGRADE.md from release diff * update formatting in UPGRADE.md * add style props to upgrade guide * update div references * fix jscodeshift call * add package install step * more button rules * add button isPending rule * codemods for checkboxgroup, form, inlinealert, link * port codemods to babel and implement import renaming (#159) * port codemods to babel and implement import renaming * run end to end transform test * fix unrenamed components * add missing deps * Codemod tests A-L (#161) * Codemod tests S-Z (#160) * setup to use jscodeshift transforms only * fix file paths * remove prefixes from tests * fix __dirname * early return if not in changes list * use path.traverse * improve adding new imports * typescript improvements * formatting * improve updatePropNameAndValue to traverse prop value expression for string literal * supporting adding to existing import statement if exists * improve existing import check * Codemod tests M-R (#165) * add tests m-r * update imports with section --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> * update tests * fix more snapshots * more changes * fix adding additional prop when not matched * update prop name only if value is updated * more snapshot fixes * more snapshot updages * update changes * Fix RadioGroup codemods (#167) * update updateComponentWithinCollection * Fix imports and item replacement (#169) * add Button -> LinkButton test * add back nearest collection parent check * Convert DimensionValue to pixel value (#170) * convert dimension value to pixel value * add todo comment, update snapshot tests * spacing --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> Co-authored-by: Reid Barber <chabarbe@adobe.com> * simplify tooltip placement change * remove Divider from Dialog * fix style props imports * fix test for import aliases * fix tooltip codemods * fix import tests * update dialog functino transform * Add additional css units to pixel value conversion (#173) * add additional css units * update picker test --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> * fix style calls without conditions * update UPGRADE.md * don't update Provider * add placeholder for tabs update * update TODO comments * Update convertDimensions (#178) * add case for sizing to convet dimension * remove 100% --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> Co-authored-by: Reid Barber <chabarbe@adobe.com> * fix deps * update TODOs in snapshots * fix resolutions for recast * update UPGRADE.md after release * remove contextualHelp changes * add contextualhelp test * add codemods for new components in latest release * fix ColorField test * fix Item and Section getting imported from S2 * comment for Breadcrumbs nav and leave Item/Section imports * fix key updating to id on v3 Items * leave comment for invalid style prop usage * fix build * improve CLI UX * install unplugin-parcel-macros automatically * add DialogTrigger render function codemod * standardize comment leading space * update remaining tests * add built CLI for testing * Revert "add built CLI for testing" This reverts commit 0efbac5a9e4ce664b71ecbe2963e3006a0ea0539. * use unique alias if newly imported name already exists in scope * improve macro setup and next steps UX * fix info to informative changes in statuslight and inlinealert * preserve comment if the first line gets removed (i.e. license header) * leave a comment if we couldn't detect parent collection component for Item/Section * update left/right style props to use start/end in macro --------- Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: Devon Govett <govett@adobe.com> Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Yihui Liao <yliao@adobe.com> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> Co-authored-by: Devon Govett <devongovett@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://jira.corp.adobe.com/browse/RSP-1307
✅ Pull Request Checklist:
📝 Test Instructions:
Review spec at
./specs/accessibility/Autocomplete.mdx🧢 Your Team:
Accessibility