Tabs design updates #1785
Merged
Tabs design updates #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Need to update Tabs.chromatic.tsx as well
should just be able to replace the internal of the Template with
please note that I only kept the first line of Text, so that they fit more nicely on the chromatic page
<Tabs {...args} aria-label="Tab example" maxWidth={500}>
<TabList>
<Item title="Tab 1" key="val1" />
<Item title="Tab 2" key="val2" />
<Item title="Tab 3" key="val3" />
<Item title="Tab 4" key="val4" />
<Item title="Tab 5" key="val5" />
</TabList>
<TabPanels>
<Item title="Tab 1" key="val1">
<Content margin="size-160">
<Heading>Tab Body 1</Heading>
<Text>
Dolore ex esse laboris elit magna esse sunt. Pariatur in veniam Lorem est occaecat do magna nisi mollit ipsum sit adipisicing fugiat ex. Pariatur ullamco exercitation ea qui adipisicing.
</Text>
</Content>
</Item>
<Item title="Tab 2" key="val2">
<Content margin="size-160">
<Heading>Tab Body 2</Heading>
<Text>
Dolore ex esse laboris elit magna esse sunt. Pariatur in veniam Lorem est occaecat do magna nisi mollit ipsum sit adipisicing fugiat ex. Pariatur ullamco exercitation ea qui adipisicing.
</Text>
</Content>
</Item>
<Item title="Tab 3" key="val3">
<Content margin="size-160">
<Heading>Tab Body 3</Heading>
<Text>
Dolore ex esse laboris elit magna esse sunt. Pariatur in veniam Lorem est occaecat do magna nisi mollit ipsum sit adipisicing fugiat ex. Pariatur ullamco exercitation ea qui adipisicing.
</Text>
</Content>
</Item>
<Item title="Tab 4" key="val4">
<Content margin="size-160">
<Heading>Tab Body 4</Heading>
<Text>
Dolore ex esse laboris elit magna esse sunt. Pariatur in veniam Lorem est occaecat do magna nisi mollit ipsum sit adipisicing fugiat ex. Pariatur ullamco exercitation ea qui adipisicing.
</Text>
</Content>
</Item>
<Item title="Tab 5" key="val5">
<Content margin="size-160">
<Heading>Tab Body 5</Heading>
<Text>
Dolore ex esse laboris elit magna esse sunt. Pariatur in veniam Lorem est occaecat do magna nisi mollit ipsum sit adipisicing fugiat ex. Pariatur ullamco exercitation ea qui adipisicing.
</Text>
</Content>
</Item>
</TabPanels>
</Tabs>
|
Build successful! 🎉 |
dannify
previously approved these changes
Apr 14, 2021
|
Build successful! 🎉 |
|
Build successful! 🎉 |
dannify
approved these changes
Apr 14, 2021
majornista
pushed a commit
to majornista/react-spectrum-v3
that referenced
this pull request
May 19, 2021
* Tabs updates * update chromatic story * Remove Content wrapper and title from panels * lint Co-authored-by: Rob Snow <rsnow@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1755 #1737
<TabList>and<TabPanels>textValueprop on<Item>elements in tabs since we don't support typeahead there anyway.