Skip to content

Always show clear button when mobile combobox has validation state #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2021

Conversation

devongovett
Copy link
Member

Because the validation icon is visible, show the clear button even when the field is empty so there isn't empty space like we do for loading states.

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@devongovett devongovett merged commit 415888d into main May 28, 2021
@devongovett devongovett deleted the combobox-invalid-clear branch May 28, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants