Skip to content

Update TooltipTrigger docs to mention trigger and tooltip ordering (#1245) #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2021
Merged

Update TooltipTrigger docs to mention trigger and tooltip ordering (#1245) #2006

merged 2 commits into from
Jun 11, 2021

Conversation

reidbarber
Copy link
Member

Closes #1245

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check docs at React Spectrum -> Tooltip -> Content

🧢 Your Project:

@reidbarber reidbarber added the small review Easy to review PR label Jun 10, 2021
@adobe-bot
Copy link

Build successful! 🎉

LFDanLu
LFDanLu previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

snowystinger
snowystinger reviewed Jun 11, 2021
View reviewed changes
@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for catching that in menu trigger as well

@reidbarber reidbarber merged commit 9366ce6 into main Jun 11, 2021
@reidbarber reidbarber deleted the Issue-1245 branch June 11, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@dannify dannify dannify approved these changes

@LFDanLu LFDanLu LFDanLu left review comments

@devongovett devongovett Awaiting requested review from devongovett

Assignees
No one assigned
Labels
small review Easy to review PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TooltipTrigger docs to mention trigger and tooltip ordering
5 participants
@reidbarber @adobe-bot @snowystinger @LFDanLu @dannify